-
Notifications
You must be signed in to change notification settings - Fork 65
apollo_http_server_config: split config to dynamic and static #11422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apollo_http_server_config: split config to dynamic and static #11422
Conversation
cee0d32 to
8de28d0
Compare
|
Artifacts upload workflows: |
77ae4cf to
3093d02
Compare
TzahiTaub
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TzahiTaub reviewed 13 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware).
crates/apollo_http_server/src/http_server.rs line 72 at r1 (raw file):
// Parses the bind address from HttpServerConfig, returning an error for invalid addresses. let HttpServerStaticConfig { ip, port } = self.config.static_config;
If you already made a function and everything
Suggestion:
let (ip, port) = self.config.ip_and_port();
matanl-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matanl-starkware reviewed 13 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware).
crates/apollo_http_server_config/src/config.rs line 36 at r1 (raw file):
} pub fn ip_and_port(&self) -> (IpAddr, u16) {
Consider renaming and/or change the return value
Suggestion (i):
endpointCode snippet (ii):
pub fn address(&self) -> SocketAddr3093d02 to
93ae2b1
Compare
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Itay-Tsabary-Starkware made 1 comment.
Reviewable status: 12 of 13 files reviewed, 1 unresolved discussion (waiting on @matanl-starkware and @TzahiTaub).
crates/apollo_http_server/src/http_server.rs line 72 at r1 (raw file):
Previously, TzahiTaub (Tzahi) wrote…
If you already made a function and everything
Right, missed this one, fixed 🙏
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Itay-Tsabary-Starkware resolved 1 discussion.
Reviewable status: 12 of 13 files reviewed, all discussions resolved (waiting on @matanl-starkware and @TzahiTaub).
70acfc6 to
bdae043
Compare
a965339 to
110efd6
Compare
bdae043 to
33c5a71
Compare
33c5a71 to
a2c02f2
Compare
Merge activity
|
a2c02f2 to
e4e0c77
Compare
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Itay-Tsabary-Starkware reviewed 16 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware).
f9d0ef6

No description provided.