apollo_batcher: define custom input task type

[yoavGrs]

No description provided.

[reviewable-StarkWare]

This change is 

[yoavGrs]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• apollo_batcher: add revert task #11451 : 2 dependent PRs (#11496 , #11516 )
• apollo_batcher: define custom input task type #11595 👈 (View in Graphite)
• apollo_batcher: wait for revert result #11484
• apollo_batcher: perform commitment tasks #11442
• main-v0.14.1-committer

This stack of pull requests is managed by Graphite. Learn more about stacking.

[dorimedini-starkware]

@dorimedini-starkware reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @amosStarkware and @yoavGrs).

---

crates/apollo_committer_types/src/communication.rs line 55 at r1 (raw file):

    CommitBlock(CommitBlockRequest),
    RevertBlock(RevertBlockRequest),
}

is this still used...? if so, where and why?

Code quote:

#[derive(Serialize, Deserialize, Clone, AsRefStr, EnumDiscriminants)]
#[strum_discriminants(
    name(CommitterRequestLabelValue),
    derive(IntoStaticStr, EnumIter, EnumVariantNames),
    strum(serialize_all = "snake_case")
)]
pub enum CommitterRequest {
    CommitBlock(CommitBlockRequest),
    RevertBlock(RevertBlockRequest),
}

[yoavGrs]

@yoavGrs made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @amosStarkware and @dorimedini-starkware).

---

crates/apollo_committer_types/src/communication.rs line 55 at r1 (raw file):

Previously, dorimedini-starkware wrote…

is this still used...? if so, where and why?

The "application" use of this struct was replaced by CommitterTaskInput.

[dorimedini-starkware]

@dorimedini-starkware reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @amosStarkware).

[amosStarkware]

@amosStarkware reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yoavGrs).

---

crates/apollo_batcher/src/commitment_manager/types.rs line 15 at r2 (raw file):

/// Input for commitment tasks.
pub(crate) enum CommitterTaskInput {

Can you rename to TaskInput?
So it's not so similar to CommitmentTask.
can also be done later.
Also - why do you now need this type? and the fancy Display function?

Code quote:

pub(crate) enum CommitterTaskInput {

[amosStarkware]

@amosStarkware resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yoavGrs).

[dorimedini-starkware]

@dorimedini-starkware reviewed 2 files and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yoavGrs).