-
Notifications
You must be signed in to change notification settings - Fork 65
starknet_os: add proof virtual os output header #11704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
c5a5f14 to
e685247
Compare
7cdda56 to
509d888
Compare
e685247 to
36d3421
Compare
509d888 to
2f0bb7a
Compare
Yoni-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Yoni-Starkware made 4 comments.
Reviewable status: 0 of 10 files reviewed, 4 unresolved discussions (waiting on @meship-starkware and @noaov1).
crates/apollo_starknet_os_program/src/cairo/starkware/starknet/core/os/virtual_os_output.cairo line 1 at r1 (raw file):
struct VirtualOsOutputHeader {
Document this struct (use cursor)
crates/apollo_starknet_os_program/src/cairo/starkware/starknet/core/os/virtual_os_output.cairo line 4 at r1 (raw file):
version: felt, prev_block_number: felt, prev_block_hash: felt,
Suggestion:
base_block_number: felt,
base_block_hash: felt,crates/starknet_api/src/test_utils.rs line 378 at r1 (raw file):
pub fn snos_proof_facts_for_testing() -> Self { let program_hash = felt!("0x4"); let version = felt!("0x0");
Suggestion:
Felt::ZERO;crates/starknet_api/src/test_utils.rs line 390 at r1 (raw file):
let config_hash = felt!("0x1"); // This fields are verified only by the contract but assumed as part of the proof facts in // the OS.
Suggestion:
// These fields are not verified by the OS (they are application-related).36d3421 to
d73288a
Compare
2f0bb7a to
0971608
Compare
d73288a to
5f68ebb
Compare
0971608 to
69b76e6
Compare
5f68ebb to
216ba3e
Compare
69b76e6 to
0bdd5f5
Compare
Yoni-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Yoni-Starkware reviewed 8 files and all commit messages, made 3 comments, and resolved 4 discussions.
Reviewable status: 8 of 10 files reviewed, 3 unresolved discussions (waiting on @meship-starkware and @noaov1).
crates/apollo_starknet_os_program/src/cairo/starkware/starknet/core/os/virtual_os_output.cairo line 1 at r3 (raw file):
// The header of a proof created by the virtual OS.
Suggestion:
// The header of the virtual OS output.crates/apollo_starknet_os_program/src/cairo/starkware/starknet/core/os/virtual_os_output.cairo line 4 at r3 (raw file):
struct VirtualOsOutputHeader { version: felt, // The block number and hash that this proof is referencing.
Suggestion:
// The block number and hash that this run is based on.crates/apollo_starknet_os_program/src/cairo/starkware/starknet/core/os/virtual_os_output.cairo line 8 at r3 (raw file):
base_block_hash: felt, starknet_os_config_hash: felt, // The account address that is authorized to use this proof.
Suggestion:
// The account address that is authorized to run transactions.0bdd5f5 to
cdd4efd
Compare
216ba3e to
07a97a2
Compare
meship-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@meship-starkware made 4 comments.
Reviewable status: 3 of 10 files reviewed, 3 unresolved discussions (waiting on @noaov1 and @Yoni-Starkware).
crates/apollo_starknet_os_program/src/cairo/starkware/starknet/core/os/virtual_os_output.cairo line 1 at r1 (raw file):
Previously, Yoni-Starkware (Yoni) wrote…
Document this struct (use cursor)
Done.
crates/apollo_starknet_os_program/src/cairo/starkware/starknet/core/os/virtual_os_output.cairo line 1 at r3 (raw file):
// The header of a proof created by the virtual OS.
Done.
crates/apollo_starknet_os_program/src/cairo/starkware/starknet/core/os/virtual_os_output.cairo line 4 at r3 (raw file):
struct VirtualOsOutputHeader { version: felt, // The block number and hash that this proof is referencing.
Done.
crates/apollo_starknet_os_program/src/cairo/starkware/starknet/core/os/virtual_os_output.cairo line 8 at r3 (raw file):
base_block_hash: felt, starknet_os_config_hash: felt, // The account address that is authorized to use this proof.
Done.
Yoni-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Yoni-Starkware reviewed 7 files and all commit messages, made 1 comment, and resolved 3 discussions.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @noaov1).
07a97a2 to
abacec2
Compare
cdd4efd to
d7be89f
Compare
Yoni-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Yoni-Starkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @noaov1).
abacec2 to
ad3f1bf
Compare
d7be89f to
763b193
Compare
ad3f1bf to
5ef3a7f
Compare
763b193 to
15526fe
Compare

No description provided.