Skip to content

Conversation

@meship-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

meship-starkware commented Jan 14, 2026

@meship-starkware meship-starkware marked this pull request as ready for review January 14, 2026 07:49
@meship-starkware meship-starkware force-pushed the meship/verify_block_number_and_hash branch from c5a5f14 to e685247 Compare January 14, 2026 08:02
@meship-starkware meship-starkware force-pushed the meship/add_snos_proof_fact_to_the_os branch from 7cdda56 to 509d888 Compare January 14, 2026 08:02
@meship-starkware meship-starkware force-pushed the meship/verify_block_number_and_hash branch from e685247 to 36d3421 Compare January 14, 2026 09:39
@meship-starkware meship-starkware force-pushed the meship/add_snos_proof_fact_to_the_os branch from 509d888 to 2f0bb7a Compare January 14, 2026 09:39
Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yoni-Starkware made 4 comments.
Reviewable status: 0 of 10 files reviewed, 4 unresolved discussions (waiting on @meship-starkware and @noaov1).


crates/apollo_starknet_os_program/src/cairo/starkware/starknet/core/os/virtual_os_output.cairo line 1 at r1 (raw file):

struct VirtualOsOutputHeader {

Document this struct (use cursor)


crates/apollo_starknet_os_program/src/cairo/starkware/starknet/core/os/virtual_os_output.cairo line 4 at r1 (raw file):

    version: felt,
    prev_block_number: felt,
    prev_block_hash: felt,

Suggestion:

    base_block_number: felt,
    base_block_hash: felt,

crates/starknet_api/src/test_utils.rs line 378 at r1 (raw file):

    pub fn snos_proof_facts_for_testing() -> Self {
        let program_hash = felt!("0x4");
        let version = felt!("0x0");

Suggestion:

Felt::ZERO;

crates/starknet_api/src/test_utils.rs line 390 at r1 (raw file):

        let config_hash = felt!("0x1");
        // This fields are verified only by the contract but assumed as part of the proof facts in
        // the OS.

Suggestion:

        // These fields are not verified by the OS (they are application-related).

@meship-starkware meship-starkware force-pushed the meship/verify_block_number_and_hash branch from 36d3421 to d73288a Compare January 14, 2026 13:11
@meship-starkware meship-starkware force-pushed the meship/add_snos_proof_fact_to_the_os branch from 2f0bb7a to 0971608 Compare January 14, 2026 13:11
@meship-starkware meship-starkware force-pushed the meship/verify_block_number_and_hash branch from d73288a to 5f68ebb Compare January 15, 2026 09:12
@meship-starkware meship-starkware force-pushed the meship/add_snos_proof_fact_to_the_os branch from 0971608 to 69b76e6 Compare January 15, 2026 09:12
@meship-starkware meship-starkware force-pushed the meship/verify_block_number_and_hash branch from 5f68ebb to 216ba3e Compare January 15, 2026 10:44
@meship-starkware meship-starkware force-pushed the meship/add_snos_proof_fact_to_the_os branch from 69b76e6 to 0bdd5f5 Compare January 15, 2026 10:44
@meship-starkware meship-starkware changed the base branch from meship/verify_block_number_and_hash to graphite-base/11704 January 15, 2026 10:48
Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Yoni-Starkware reviewed 8 files and all commit messages, made 3 comments, and resolved 4 discussions.
Reviewable status: 8 of 10 files reviewed, 3 unresolved discussions (waiting on @meship-starkware and @noaov1).


crates/apollo_starknet_os_program/src/cairo/starkware/starknet/core/os/virtual_os_output.cairo line 1 at r3 (raw file):

// The header of a proof created by the virtual OS.

Suggestion:

// The header of the virtual OS output.

crates/apollo_starknet_os_program/src/cairo/starkware/starknet/core/os/virtual_os_output.cairo line 4 at r3 (raw file):

struct VirtualOsOutputHeader {
    version: felt,
    // The block number and hash that this proof is referencing.

Suggestion:

   // The block number and hash that this run is based on.

crates/apollo_starknet_os_program/src/cairo/starkware/starknet/core/os/virtual_os_output.cairo line 8 at r3 (raw file):

    base_block_hash: felt,
    starknet_os_config_hash: felt,
    // The account address that is authorized to use this proof.

Suggestion:

    // The account address that is authorized to run transactions.

@meship-starkware meship-starkware force-pushed the meship/add_snos_proof_fact_to_the_os branch from 0bdd5f5 to cdd4efd Compare January 15, 2026 12:43
@meship-starkware meship-starkware changed the base branch from graphite-base/11704 to meship/verify_block_number_and_hash January 15, 2026 12:43
Copy link
Collaborator Author

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meship-starkware made 4 comments.
Reviewable status: 3 of 10 files reviewed, 3 unresolved discussions (waiting on @noaov1 and @Yoni-Starkware).


crates/apollo_starknet_os_program/src/cairo/starkware/starknet/core/os/virtual_os_output.cairo line 1 at r1 (raw file):

Previously, Yoni-Starkware (Yoni) wrote…

Document this struct (use cursor)

Done.


crates/apollo_starknet_os_program/src/cairo/starkware/starknet/core/os/virtual_os_output.cairo line 1 at r3 (raw file):

// The header of a proof created by the virtual OS.

Done.


crates/apollo_starknet_os_program/src/cairo/starkware/starknet/core/os/virtual_os_output.cairo line 4 at r3 (raw file):

struct VirtualOsOutputHeader {
    version: felt,
    // The block number and hash that this proof is referencing.

Done.


crates/apollo_starknet_os_program/src/cairo/starkware/starknet/core/os/virtual_os_output.cairo line 8 at r3 (raw file):

    base_block_hash: felt,
    starknet_os_config_hash: felt,
    // The account address that is authorized to use this proof.

Done.

@meship-starkware meship-starkware changed the base branch from meship/verify_block_number_and_hash to graphite-base/11704 January 15, 2026 14:21
Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Yoni-Starkware reviewed 7 files and all commit messages, made 1 comment, and resolved 3 discussions.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noaov1).

@meship-starkware meship-starkware force-pushed the meship/add_snos_proof_fact_to_the_os branch from cdd4efd to d7be89f Compare January 15, 2026 16:36
@meship-starkware meship-starkware changed the base branch from graphite-base/11704 to meship/verify_block_number_and_hash January 15, 2026 16:36
Copy link
Collaborator

@Yoni-Starkware Yoni-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Yoni-Starkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noaov1).

@meship-starkware meship-starkware force-pushed the meship/verify_block_number_and_hash branch from abacec2 to ad3f1bf Compare January 18, 2026 07:59
@meship-starkware meship-starkware force-pushed the meship/add_snos_proof_fact_to_the_os branch from d7be89f to 763b193 Compare January 18, 2026 07:59
@meship-starkware meship-starkware changed the base branch from meship/verify_block_number_and_hash to graphite-base/11704 January 18, 2026 09:17
@meship-starkware meship-starkware force-pushed the meship/add_snos_proof_fact_to_the_os branch from 763b193 to 15526fe Compare January 18, 2026 09:17
@meship-starkware meship-starkware changed the base branch from graphite-base/11704 to main January 18, 2026 09:17
@meship-starkware meship-starkware added this pull request to the merge queue Jan 18, 2026
Merged via the queue into main with commit 5f99350 Jan 18, 2026
23 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants