starknet_committer: add number of modifications to BlockMeasurement and impl set function

[rotem-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[rotem-starkware]

• apollo_committer: add emptied storage leaves metrics #11920
• starknet_committer: add number of empty leaves to TimeMeasurementTrait #11919
• apollo_committer: add number of modifications of each trie per block #11918
• starknet_committer_cli: add number of modifications plot to benchmark with backward compatibility #12105
• starknet_committer: add number of modifications to BlockMeasurement and impl set function #11917 👈 (View in Graphite)
• apollo_committer: refactor update_metrics #11972
• starknet_committer: define BlockDurations and use it in BlockMeasurement #11971
• starknet_committer: rename timing_util and TimeMeasurementTrait and structs #11970
• apollo_committer: add offset metric #11916
• apollo_committer: remove facts terminology from commit_block #11915
• apollo_committer: update time_measurement and record metrics #11403
• apollo_committer: define per block metrics #11154
• apollo_committer: receive TimeMeasurementTrait in commit_state_diff #11608
• starknet_committer: move BenchmarkTimeMeasurement to starknet_committer_cli #11607 : 1 other dependent PR (#11747 )
• starknet_committer: backward compatibility for csvs read in committer benchmarking #11890
• main-v0.14.1-committer

This stack of pull requests is managed by Graphite. Learn more about stacking.

[yoavGrs]

@yoavGrs reviewed 2 files and all commit messages, and made 2 comments.
Reviewable status: 2 of 4 files reviewed, 2 unresolved discussions (waiting on @rotem-starkware).

---

crates/starknet_committer/src/block_committer/timing_util.rs line 106 at r1 (raw file):

    pub n_contracts_trie_modifications: usize,
    pub n_classes_trie_modifications: usize,
}

Consider dividing into sub-structs.
non-blocking

Suggestion:

    pub block_duration: BlockDuration,
    pub block_modifications: BlockModifications,
}

---

crates/starknet_committer/src/block_committer/commit.rs line 45 at r1 (raw file):

        let n_storage_tries_modifications =
            actual_storage_updates.values().map(|value| value.len()).sum();
        time_measurement.set_number_of_modifications(

It's not only about timing...
Do you plan to rename it and timing_util.rs? (not in this PR)
Or separating timing from counting?

Suggestion:

measurements

[rotem-starkware]

@rotem-starkware made 2 comments and resolved 1 discussion.
Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on @yoavGrs).

---

crates/starknet_committer/src/block_committer/commit.rs line 45 at r1 (raw file):

Previously, yoavGrs wrote…

It's not only about timing...
Do you plan to rename it and timing_util.rs? (not in this PR)
Or separating timing from counting?

Done, in PR #11970

---

crates/starknet_committer/src/block_committer/timing_util.rs line 106 at r1 (raw file):

Previously, yoavGrs wrote…

Consider dividing into sub-structs.
non-blocking

Done, in separate PRs

[yoavGrs]

@yoavGrs partially reviewed 4 files, made 1 comment, and resolved 1 discussion.
Reviewable status: 3 of 6 files reviewed, 1 unresolved discussion (waiting on @rotem-starkware).

---

crates/starknet_committer/src/block_committer/measurements_util.rs line 69 at r2 (raw file):

        n_storage_tries_modifications: usize,
        n_contracts_trie_modifications: usize,
        n_classes_trie_modifications: usize,

Suggestion:

        block_modificationsC_counts: BlockModificationsCounts,

[rotem-starkware]

@rotem-starkware made 1 comment.
Reviewable status: 0 of 6 files reviewed, 1 unresolved discussion (waiting on @yoavGrs).

---

crates/starknet_committer/src/block_committer/measurements_util.rs line 69 at r2 (raw file):

        n_storage_tries_modifications: usize,
        n_contracts_trie_modifications: usize,
        n_classes_trie_modifications: usize,

Done.

[yoavGrs]

@yoavGrs reviewed 6 files and all commit messages, made 1 comment, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @rotem-starkware).

[dorimedini-starkware]

@dorimedini-starkware reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @rotem-starkware).

---

crates/starknet_committer_cli/src/utils.rs line 198 at r4 (raw file):

                    "n_storage_tries_modifications",
                    "n_contracts_trie_modifications",
                    "n_classes_trie_modifications",

do you need to update the python scripts for these new columns?
any backward-compatibility issues?

Code quote:

                    "n_storage_tries_modifications",
                    "n_contracts_trie_modifications",
                    "n_classes_trie_modifications",

[rotem-starkware]

@rotem-starkware made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware).

---

crates/starknet_committer_cli/src/utils.rs line 198 at r4 (raw file):

Previously, dorimedini-starkware wrote…

do you need to update the python scripts for these new columns?
any backward-compatibility issues?

I actually didn't add plotting of those values, but that's a good idea.
PTAL at the next PR in the stack.

[dorimedini-starkware]

@dorimedini-starkware resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @rotem-starkware).

[dorimedini-starkware]

@dorimedini-starkware made 1 comment.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @rotem-starkware).