Skip to content

starknet_committer_cli: add number of modifications plot to benchmark with backward compatibility#12105

Merged
rotem-starkware merged 1 commit intomain-v0.14.1-committerfrom
01-28-scripts_add_number_of_modifications_plotting_to_committer_benchmark
Jan 29, 2026
Merged

starknet_committer_cli: add number of modifications plot to benchmark with backward compatibility#12105
rotem-starkware merged 1 commit intomain-v0.14.1-committerfrom
01-28-scripts_add_number_of_modifications_plotting_to_committer_benchmark

Conversation

@rotem-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

rotem-starkware commented Jan 28, 2026

@rotem-starkware
Copy link
Contributor Author

scripts/committer/committer_benchmark_plotting.py line 116 at r1 (raw file):

            for col in modifications_columns:
                if col in data[0]:
                    self.modifications_data[col] = [int(row[col]) for row in data]

Backward compatibility - if those fields don't exist in the csv, it skips

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @rotem-starkware).

@rotem-starkware rotem-starkware changed the base branch from 01-14-starknet_committer_add_number_of_modifications_to_blockmeasurement_and_impl_set_function to graphite-base/12105 January 29, 2026 05:10
@rotem-starkware rotem-starkware force-pushed the 01-28-scripts_add_number_of_modifications_plotting_to_committer_benchmark branch from 83c23f6 to bf135bd Compare January 29, 2026 09:12
@rotem-starkware rotem-starkware changed the base branch from graphite-base/12105 to main-v0.14.1-committer January 29, 2026 09:12
@rotem-starkware rotem-starkware added this pull request to the merge queue Jan 29, 2026
Merged via the queue into main-v0.14.1-committer with commit 382c997 Jan 29, 2026
16 of 33 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 31, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants