apollo_committer_types: extend mock committer client#12115
apollo_committer_types: extend mock committer client#12115yoavGrs merged 1 commit intomain-v0.14.1-committerfrom
Conversation
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 4 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @amosStarkware and @yoavGrs).
crates/apollo_committer_types/src/test_utils.rs line 49 at r1 (raw file):
Self { inner, offset: Arc::new(Mutex::new(offset)) } } pub async fn set_offset(&self, offset: BlockNumber) {
non blocking
Suggestion:
}
pub async fn set_offset(&self, offset: BlockNumber) {
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @amosStarkware and @yoavGrs).
crates/apollo_committer_types/src/test_utils.rs line 55 at r1 (raw file):
pub fn get_offset(&self) -> Arc<Mutex<BlockNumber>> { Arc::clone(&self.offset) }
why return a locked offset and not just a block number?
Suggestion:
pub async fn get_offset(&self) -> BlockNumber {
self.offset.lock().await
}
yoavGrs
left a comment
There was a problem hiding this comment.
@yoavGrs made 2 comments and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @amosStarkware and @dorimedini-starkware).
crates/apollo_committer_types/src/test_utils.rs line 49 at r1 (raw file):
Previously, dorimedini-starkware wrote…
non blocking
Done.
crates/apollo_committer_types/src/test_utils.rs line 55 at r1 (raw file):
Previously, dorimedini-starkware wrote…
why return a locked offset and not just a block number?
In the test, I'm moving the committer client before checking the offset.
80a3287 to
9addf4b
Compare
23b61db to
024a84f
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @amosStarkware).
9addf4b to
c080dcb
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @amosStarkware).

No description provided.