Skip to content

apollo_committer_types: extend mock committer client#12115

Merged
yoavGrs merged 1 commit intomain-v0.14.1-committerfrom
yoav/apollo_committer_types/mock_committer_util
Feb 1, 2026
Merged

apollo_committer_types: extend mock committer client#12115
yoavGrs merged 1 commit intomain-v0.14.1-committerfrom
yoav/apollo_committer_types/mock_committer_util

Conversation

@yoavGrs
Copy link
Contributor

@yoavGrs yoavGrs commented Jan 28, 2026

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@github-actions
Copy link

github-actions bot commented Jan 28, 2026

@yoavGrs yoavGrs self-assigned this Jan 28, 2026
@yoavGrs yoavGrs marked this pull request as ready for review January 28, 2026 15:52
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@dorimedini-starkware reviewed 4 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @amosStarkware and @yoavGrs).


crates/apollo_committer_types/src/test_utils.rs line 49 at r1 (raw file):

        Self { inner, offset: Arc::new(Mutex::new(offset)) }
    }
    pub async fn set_offset(&self, offset: BlockNumber) {

non blocking

Suggestion:

    }
    
    pub async fn set_offset(&self, offset: BlockNumber) {

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware made 1 comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @amosStarkware and @yoavGrs).


crates/apollo_committer_types/src/test_utils.rs line 55 at r1 (raw file):

    pub fn get_offset(&self) -> Arc<Mutex<BlockNumber>> {
        Arc::clone(&self.offset)
    }

why return a locked offset and not just a block number?

Suggestion:

    pub async fn get_offset(&self) -> BlockNumber {
        self.offset.lock().await
    }

@yoavGrs yoavGrs changed the base branch from yoav/apollo_batcher/commitment_manager_types/call_revert to graphite-base/12115 January 29, 2026 12:26
Copy link
Contributor Author

@yoavGrs yoavGrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yoavGrs made 2 comments and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @amosStarkware and @dorimedini-starkware).


crates/apollo_committer_types/src/test_utils.rs line 49 at r1 (raw file):

Previously, dorimedini-starkware wrote…

non blocking

Done.


crates/apollo_committer_types/src/test_utils.rs line 55 at r1 (raw file):

Previously, dorimedini-starkware wrote…

why return a locked offset and not just a block number?

In the test, I'm moving the committer client before checking the offset.

@yoavGrs yoavGrs force-pushed the yoav/apollo_committer_types/mock_committer_util branch from 80a3287 to 9addf4b Compare January 29, 2026 12:27
@yoavGrs yoavGrs force-pushed the graphite-base/12115 branch from 23b61db to 024a84f Compare January 29, 2026 12:27
@yoavGrs yoavGrs changed the base branch from graphite-base/12115 to main-v0.14.1-committer January 29, 2026 12:27
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 file and all commit messages, and resolved 1 discussion.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @amosStarkware).

@yoavGrs yoavGrs force-pushed the yoav/apollo_committer_types/mock_committer_util branch from 9addf4b to c080dcb Compare February 1, 2026 07:45
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @amosStarkware).

@yoavGrs yoavGrs added this pull request to the merge queue Feb 1, 2026
Merged via the queue into main-v0.14.1-committer with commit a713750 Feb 1, 2026
26 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants