apollo_proc_macros: features visibility

[yoavGrs]

No description provided.

[yoavGrs]

• apollo_batcher: use mock committer client #12116
• apollo_committer_types: extend mock committer client #12115
• apollo_batcher: full revert commitment flow #11496
• apollo_proc_macros: features visibility #12060 👈 (View in Graphite)
• apollo_batcher: add revert task #11451 : 1 other dependent PR (#11516 )
• apollo_batcher: define custom input task type #11595
• apollo_batcher: wait for revert result #11484
• apollo_batcher: perform commitment tasks #11442
• apollo_committer: use rocks db storage #11733
• apollo_integration_tests: path with node index #11817
• apollo_committer_config: add db path to config #11800
• main-v0.14.1-committer

This stack of pull requests is managed by Graphite. Learn more about stacking.

[reviewable-StarkWare]

This change is 

[dorimedini-starkware]

@dorimedini-starkware reviewed 1 file and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yoavGrs).

---

crates/apollo_proc_macros/src/lib.rs line 463 at r1 (raw file):

                .to_compile_error()
                .into();
        }

Suggestion:

        other_item => {
            return Error::new_spanned(&input, "Cannot override the `#[visibility]` of item {other_item:?}.")
                .to_compile_error()
                .into();
        }

[yoavGrs]

@yoavGrs made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware).

---

crates/apollo_proc_macros/src/lib.rs line 463 at r1 (raw file):

                .to_compile_error()
                .into();
        }

syn::Item doesn't implement either std::fmt::Debug or std::fmt::Display.

[dorimedini-starkware]

@dorimedini-starkware made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yoavGrs).

---

crates/apollo_proc_macros/src/lib.rs line 463 at r1 (raw file):

Previously, yoavGrs wrote…

syn::Item doesn't implement either std::fmt::Debug or std::fmt::Display.

godammit
is there some type_name function? pretty sure there is, and would help to know which item is problematic (this may occur because we misplaced the attribute and are applying it on an unexpected item)

[yoavGrs]

@yoavGrs made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware).

---

crates/apollo_proc_macros/src/lib.rs line 463 at r1 (raw file):

Previously, dorimedini-starkware wrote…

godammit
is there some type_name function? pretty sure there is, and would help to know which item is problematic (this may occur because we misplaced the attribute and are applying it on an unexpected item)

I don't find...

[dorimedini-starkware]

@dorimedini-starkware made 1 comment and resolved 1 discussion.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @yoavGrs).

---

crates/apollo_proc_macros/src/lib.rs line 458 at r1 (raw file):

        Item::Type(ItemType { ref mut vis, .. }) => *vis = visibility,
        Item::Union(ItemUnion { ref mut vis, .. }) => *vis = visibility,
        Item::Use(ItemUse { ref mut vis, .. }) => *vis = visibility,

non-blocking

Suggestion:

        Item::Const(ItemConst { ref mut vis, .. })
        | Item::Enum(ItemEnum { ref mut vis, .. })
        | Item::ExternCrate(ItemExternCrate { ref mut vis, .. })
        | Item::Fn(ItemFn { ref mut vis, .. })
        | Item::Mod(ItemMod { ref mut vis, .. })
        | Item::Static(ItemStatic { ref mut vis, .. })
        | Item::Struct(ItemStruct { ref mut vis, .. })
        | Item::Trait(ItemTrait { ref mut vis, .. })
        | Item::TraitAlias(ItemTraitAlias { ref mut vis, .. })
        | Item::Type(ItemType { ref mut vis, .. })
        | Item::Union(ItemUnion { ref mut vis, .. })
        | Item::Use(ItemUse { ref mut vis, .. }) => *vis = visibility,

[yoavGrs]

@yoavGrs made 1 comment and resolved 1 discussion.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @dorimedini-starkware).

---

crates/apollo_proc_macros/src/lib.rs line 458 at r1 (raw file):

Previously, dorimedini-starkware wrote…

non-blocking

Done

[dorimedini-starkware]

@dorimedini-starkware reviewed 1 file and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yoavGrs).