apollo_http_server: add test for the max_request_body_size config

[ArniStarkware]

Note

Low Risk
Test-only changes plus a small test utility builder setter; no production logic changes, with low risk beyond potential test flakiness from size assumptions.

Overview
Adds a parameterized test ensuring the HTTP server enforces static_config.max_request_body_size for both deprecated gateway and RPC add_tx endpoints, expecting 200 OK for allowed sizes and 413 PAYLOAD_TOO_LARGE when exceeded.

Extends HttpClientServerSetupBuilder test utilities with with_max_request_body_size() to easily override this config in tests.

^{Written by Cursor Bugbot for commit f091655. This will update automatically on new commits. Configure here.}

[reviewable-StarkWare]

This change is 

[ArniStarkware]

• apollo_http_server: add dynamic config size validation #12438
• apollo_http_server: add test for the max_request_body_size config #12371 👈 (View in Graphite)
• apollo_http_server: add configurable max_request_body_size as 5mb #12366
• main-v0.14.1-committer

This stack of pull requests is managed by Graphite. Learn more about stacking.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

[ArniStarkware]

crates/apollo_http_server/src/http_server_test.rs line 430 at r1 (raw file):

    assert_eq!(
        response.status(),
        reqwest::StatusCode::PAYLOAD_TOO_LARGE,

@eitanm-starkware regarding the: RPC provider doesn't return an informative error when sncast declare fails.
This is the error message that is returned by our HTTP server.
Some message like this should return at some size...

Code quote:

        reqwest::StatusCode::PAYLOAD_TOO_LARGE,

[TzahiTaub]

@TzahiTaub reviewed 4 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware).

---

crates/apollo_http_server/src/http_server_test.rs line 430 at r1 (raw file):

Previously, ArniStarkware (Arnon Hod) wrote…

@eitanm-starkware regarding the: RPC provider doesn't return an informative error when sncast declare fails.
This is the error message that is returned by our HTTP server.
Some message like this should return at some size...

@eitanm-starkware Should this be wrapped in a starknet error as this is what RPC providers always expect? Currently is a standard http error

---

crates/apollo_http_server/src/http_server_test.rs line 385 at r3 (raw file):

        mock_gateway_client.expect_add_tx().times(1).return_const(Ok(default_gateway_output()));
    }
    let http_client = HttpClientServerSetupBuilder::new(index)

Can we remove the index from the input?

Suggestion:

HttpClientServerSetupBuilder::new(unique_u16!())

[ArniStarkware]

crates/apollo_http_server/src/http_server_test.rs line 430 at r1 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

@eitanm-starkware Should this be wrapped in a starknet error as this is what RPC providers always expect? Currently is a standard http error

It will be hard to implement and maintain a wrap of this error with a starknet error.

[ArniStarkware]

crates/apollo_http_server/src/http_server_test.rs line 385 at r3 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

Can we remove the index from the input?

Your suggestion, as written, does not work. I tried it now.

thread 'http_server::http_server_test::request_body_size_limit_enforced::case_3_add_deprecated_gateway_tx_too_large' (684288) panicked at crates/apollo_http_server/src/test_utils.rs:171:17:
Failed spawning test http server