apollo_http_server: add dynamic config size validation

[ArniStarkware]

Note

Low Risk
Small, self-contained config validation and test changes; risk is limited to rejecting previously-accepted invalid configurations at startup/validation time.

Overview
Adds a cross-field config validation on HttpServerConfig to ensure static_config.max_request_body_size is greater than dynamic_config.max_sierra_program_size, returning a ValidationError when violated.

Introduces a focused unit test (config_test.rs) and wires it into the crate’s test module setup to prevent regressions.

^{Written by Cursor Bugbot for commit 60de1e9. This will update automatically on new commits. Configure here.}

[reviewable-StarkWare]

This change is 

[ArniStarkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• apollo_http_server: add dynamic config size validation #12438 👈 (View in Graphite)
• apollo_http_server: add test for the max_request_body_size config #12371
• apollo_http_server: add configurable max_request_body_size as 5mb #12366
• main-v0.14.1-committer

This stack of pull requests is managed by Graphite. Learn more about stacking.

[TzahiTaub]

@TzahiTaub reviewed 2 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @ArniStarkware).

---

crates/apollo_http_server_config/src/config.rs line 140 at r1 (raw file):

    }
    Ok(())
}

As discussed, please unify. The validation here is sufficient.

Suggestion:

fn max_size_validations(http_server_config: &HttpServerConfig) -> Result<(), ValidationError> {
    let max_request_body_size = http_server_config.static_config.max_request_body_size;
    validate_dynamic_config_bounds(&http_server_config.dynamic_config, max_request_body_size)
}

pub fn validate_dynamic_config_bounds(
    dynamic_config: &HttpServerDynamicConfig,
    max_request_body_size: usize,
) -> Result<(), ValidationError> {
    if max_request_body_size <= dynamic_config.max_sierra_program_size {
        return Err(ValidationError::new(
            "max_request_body_size must be greater than max_sierra_program_size",
        ));
    }
    Ok(())
}

---

crates/apollo_http_server/src/http_server.rs line 0 at r1 (raw file):
Revert changes in this file

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

[ArniStarkware]

crates/apollo_http_server/src/http_server.rs line at r1 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

Revert changes in this file

Done.

[ArniStarkware]

@ArniStarkware made 1 comment.
Reviewable status: 0 of 4 files reviewed, 2 unresolved discussions (waiting on @TzahiTaub).

---

crates/apollo_http_server_config/src/config.rs line 140 at r1 (raw file):

Previously, TzahiTaub (Tzahi) wrote…

As discussed, please unify. The validation here is sufficient.

Done.