Skip to content

apollo_consensus: add helper function to report peer #12464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guy-starkware wants to merge 1 commit into
base: main-v0.14.1-committer
Choose a base branch
from
Open

apollo_consensus: add helper function to report peer #12464

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions crates/apollo_consensus/src/manager.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -783,6 +783,21 @@ impl<ContextT: ConsensusContext> MultiHeightManager<ContextT> {
}
}

fn report_peer(
&self,
broadcast_channels: &mut BroadcastVoteChannel,
metadata: &BroadcastedMessageMetadata,
) {
if broadcast_channels
.broadcast_topic_client
.report_peer(metadata.clone())
.now_or_never()
.is_none()
{
error!("Unable to send report_peer. {:?}", metadata);
}
}

async fn handle_proposal_known_block_info(
&mut self,
context: &mut ContextT,
Expand Down Expand Up @@ -822,14 +837,7 @@ impl<ContextT: ConsensusContext> MultiHeightManager<ContextT> {
}
(Err(e), metadata) => {
// Failed to parse consensus message. Report the peer and drop the vote.
if broadcast_channels
.broadcast_topic_client
.report_peer(metadata.clone())
.now_or_never()
.is_none()
{
error!("Unable to send report_peer. {:?}", metadata)
}
self.report_peer(broadcast_channels, &metadata);
warn!(
"Failed to parse incoming consensus vote, dropping vote. Error: {e}. Vote \
metadata: {metadata:?}"
Expand Down
Loading