starknet_os: rename standalone adjective variables

[dan-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[dan-starkware]

• workspace: rename standalone adjective variables in tests #12552
• apollo_storage: rename standalone adjective variables #12551
• starknet_os: rename standalone adjective variables #12550 👈 (View in Graphite)
• starknet_patricia: rename standalone adjective variable #12549
• blockifier: rename standalone adjective variables #12548
• apollo_consensus_orchestrator: rename standalone adjective variables #12547
• apollo_mempool: rename standalone adjective variable #12546
• main-v0.14.2

This stack of pull requests is managed by Graphite. Learn more about stacking.

[dorimedini-starkware]

@dorimedini-starkware reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dan-starkware).

---

crates/starknet_os/src/hints/hint_implementation/execution/implementation.rs line 747 at r1 (raw file):

    let result = ctx.vm.get_range(retdata, min(retdata_size, 100_usize));

    let validated_value = MaybeRelocatable::from(ctx.fetch_const(Const::Validated)?);

this name implies that this is the value that has been validated, not the value of the VALIDATED const.
I would keep the previous name, or rename to something like this

Suggestion:

validate_succeeded

[dan-starkware]

@dan-starkware made 1 comment.
Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware).

---

crates/starknet_os/src/hints/hint_implementation/execution/implementation.rs line 747 at r1 (raw file):

Previously, dorimedini-starkware wrote…

this name implies that this is the value that has been validated, not the value of the VALIDATED const.
I would keep the previous name, or rename to something like this

Done.

[dorimedini-starkware]

@dorimedini-starkware reviewed 7 files and all commit messages, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dan-starkware).