workspace: rename standalone adjective variables in tests

[dan-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[dan-starkware]

• workspace: rename standalone adjective variables in tests #12552 👈 (View in Graphite)
• apollo_storage: rename standalone adjective variables #12551
• starknet_os: rename standalone adjective variables #12550
• starknet_patricia: rename standalone adjective variable #12549
• blockifier: rename standalone adjective variables #12548
• apollo_consensus_orchestrator: rename standalone adjective variables #12547
• apollo_mempool: rename standalone adjective variable #12546
• main-v0.14.2

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Artifacts upload workflows:

• Started at 2026-02-12T22:09:51Z
• Started at 2026-02-14T07:18:18Z
• Started at 2026-02-14T07:35:47Z
• Started at 2026-02-15T12:59:06Z
• Started at 2026-02-15T12:59:05Z
• Started at 2026-02-15T14:19:35Z
• Started at 2026-02-15T14:19:34Z
• Started at 2026-02-15T20:19:25Z

[dorimedini-starkware]

@dorimedini-starkware reviewed 7 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dan-starkware).

---

crates/apollo_batcher/src/batcher_test.rs line 396 at r1 (raw file):

    let succeeded = PROPOSAL_SUCCEEDED.parse_numeric_metric::<u64>(metrics);
    let failed_count = PROPOSAL_FAILED.parse_numeric_metric::<u64>(metrics);
    let aborted = PROPOSAL_ABORTED.parse_numeric_metric::<u64>(metrics);

why rename only one of these?

Code quote:

    let started = PROPOSAL_STARTED.parse_numeric_metric::<u64>(metrics);
    let succeeded = PROPOSAL_SUCCEEDED.parse_numeric_metric::<u64>(metrics);
    let failed_count = PROPOSAL_FAILED.parse_numeric_metric::<u64>(metrics);
    let aborted = PROPOSAL_ABORTED.parse_numeric_metric::<u64>(metrics);

---

crates/apollo_l1_provider/src/test_utils.rs line 372 at r1 (raw file):

        let rejected_txs: Vec<_> = mem::take(&mut content.rejected).unwrap_or_default();
        let committed_txs: Vec<_> = mem::take(&mut content.committed).unwrap_or_default();
        let consumed: Vec<_> = mem::take(&mut content.consumed).unwrap_or_default();

Suggestion:

        let pending_txs: Vec<_> = mem::take(&mut content.uncommitted).unwrap_or_default();
        let rejected_txs: Vec<_> = mem::take(&mut content.rejected).unwrap_or_default();
        let committed_txs: Vec<_> = mem::take(&mut content.committed).unwrap_or_default();
        let consumed_txs: Vec<_> = mem::take(&mut content.consumed).unwrap_or_default();

[dan-starkware]

@dan-starkware made 1 comment, resolved 1 discussion, and dismissed @dorimedini-starkware from 2 discussions.
Reviewable status: 5 of 7 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware).

---

crates/apollo_batcher/src/batcher_test.rs line 396 at r1 (raw file):

Previously, dorimedini-starkware wrote…

why rename only one of these?

Sorry

[dorimedini-starkware]

@dorimedini-starkware reviewed 2 files and all commit messages, and resolved 1 discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dan-starkware).