blockifier: add validation for contract class manager config#12696
Open
ArniStarkware wants to merge 1 commit intomain-v0.14.2from
Open
blockifier: add validation for contract class manager config#12696ArniStarkware wants to merge 1 commit intomain-v0.14.2from
ArniStarkware wants to merge 1 commit intomain-v0.14.2from
Conversation
|
This change is |
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
ArniStarkware
force-pushed
the
arni/blockifier/validate_config/set_missing_config_validations
branch
from
e3dc405 to
16ac2a2
Compare
ArniStarkware
force-pushed
the
arni/blockifier/native_class_manager/validate_config
branch
from
6d8a853 to
4b4b855
Compare
ArniStarkware
force-pushed
the
arni/blockifier/validate_config/set_missing_config_validations
branch
from
16ac2a2 to
ef2714e
Compare
ArniStarkware
force-pushed
the
arni/blockifier/native_class_manager/validate_config
branch
from
4b4b855 to
485574f
Compare
ArniStarkware
force-pushed
the
arni/blockifier/native_class_manager/validate_config
branch
from
485574f to
6c0aca6
Compare
ArniStarkware
force-pushed
the
arni/blockifier/validate_config/set_missing_config_validations
branch
from
ef2714e to
cd4cd2f
Compare
ArniStarkware
changed the base branch from
arni/blockifier/validate_config/set_missing_config_validations
to
graphite-base/12696
ArniStarkware
force-pushed
the
graphite-base/12696
branch
from
cd4cd2f to
5047911
Compare
ArniStarkware
force-pushed
the
arni/blockifier/native_class_manager/validate_config
branch
from
6c0aca6 to
2fa38d7
Compare
ArniStarkware
changed the base branch from
graphite-base/12696
to
arni/blockifier/validate_config/set_missing_config_validations
ArniStarkware
commented
Feb 19, 2026
Contributor
Author
ArniStarkware
left a comment
ArniStarkware
left a comment
There was a problem hiding this comment.
@ArniStarkware made 1 comment and resolved 1 discussion.
Reviewable status: 0 of 4 files reviewed, all discussions resolved (waiting on avi-starkware and avivg-starkware).
ArniStarkware
force-pushed
the
arni/blockifier/native_class_manager/validate_config
branch
from
2fa38d7 to
f87f777
Compare
ArniStarkware
force-pushed
the
arni/blockifier/validate_config/set_missing_config_validations
branch
from
5047911 to
432618e
Compare
ArniStarkware
commented
Feb 19, 2026
ArniStarkware
force-pushed
the
arni/blockifier/native_class_manager/validate_config
branch
from
f87f777 to
2d0904f
Compare
Contributor
Author
|
Collides with #12717 |
ArniStarkware
changed the base branch from
arni/blockifier/validate_config/set_missing_config_validations
to
graphite-base/12696
ArniStarkware
force-pushed
the
arni/blockifier/native_class_manager/validate_config
branch
from
2d0904f to
59bea43
Compare
ArniStarkware
force-pushed
the
graphite-base/12696
branch
from
432618e to
818cea3
Compare
ArniStarkware
changed the base branch from
graphite-base/12696
to
main-v0.14.2
ArniStarkware
force-pushed
the
arni/blockifier/native_class_manager/validate_config
branch
from
59bea43 to
ab9659d
Compare
Contributor
idan-starkware
left a comment
idan-starkware
left a comment
There was a problem hiding this comment.
@idan-starkware reviewed 1 file.
Reviewable status: 1 of 5 files reviewed, all discussions resolved (waiting on avi-starkware and avivg-starkware).
avi-starkware
approved these changes
Feb 22, 2026
Collaborator
avi-starkware
left a comment
avi-starkware
left a comment
There was a problem hiding this comment.
@avi-starkware reviewed 4 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on avivg-starkware).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Mainly adds config validation and test/CI tweaks; behavior change is limited to earlier panics on previously-invalid configuration combinations.
Overview
Adds
validator-based config validation to prevent an invalid combination wherewait_on_native_compilation=truewhilerun_cairo_native=false(via a schema check onCairoNativeRunConfigand nested validation inContractClassManagerConfig).NativeClassManager::startnow validates and panics early on invalid config; tests are updated/added to cover the new validation behavior, and CI benchmarking checkout now usesfetch-depth: 0for the base-branch benchmark step.Written by Cursor Bugbot for commit ab9659d. This will update automatically on new commits. Configure here.