Skip to content

apollo_mempool: rename get_timestamp functions#13081

Closed
ayeletstarkware wants to merge 1 commit intomainfrom
ayelet/mempool/fifo/rename-get-timestamp
Closed

apollo_mempool: rename get_timestamp functions#13081
ayeletstarkware wants to merge 1 commit intomainfrom
ayelet/mempool/fifo/rename-get-timestamp

Conversation

@ayeletstarkware
Copy link
Contributor

@ayeletstarkware ayeletstarkware commented Mar 9, 2026

Note

Medium Risk
Medium risk: changes touch consensus vote handling and stream buffering/eviction logic, plus batcher proposal-finalization and L1 event plumbing, which could affect liveness if edge cases are missed. CI workflow gating was also removed, potentially increasing PR load and changing when benchmarks run.

Overview
This PR replaces apollo_l1_provider usage with a new apollo_l1_events provider across the workspace (new crates added, dependencies updated, and nextest serialized filters switched), and updates batcher metrics/error types accordingly.

It refactors batcher proposal validation finalization by removing Finish/Abort from SendProposalContent and introducing explicit finish_proposal/abort_proposal requests/responses (FinishProposalStatus), plus renames timestamp retrieval to get_batch_timestamp backed by mempool’s resolve_batch_timestamp.

On the consensus side, it deduplicates cached future votes and reports peers on equivocation, and reworks the stream handler’s inbound LRU from a single (peer, stream) cache to a two-level per-peer cache with new eviction behavior and tests. Separately, storage reader server spawning is updated to use the new spawn() API and always keep an abort handle alive.

CI workflows drop the Graphite optimize_ci job and related skip conditions, causing jobs (including benchmarks) to run unconditionally when their existing event/title guards allow.

Written by Cursor Bugbot for commit 868331c. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link

This change is Reviewable

@ayeletstarkware ayeletstarkware marked this pull request as ready for review March 9, 2026 10:19
@ayeletstarkware ayeletstarkware force-pushed the ayelet/mempool/fifo/impl-fifo-integrate-in-mempool branch from 1f06daa to b0b64d4 Compare March 9, 2026 10:39
@ayeletstarkware ayeletstarkware force-pushed the ayelet/mempool/fifo/rename-get-timestamp branch from 015a420 to f907010 Compare March 9, 2026 10:39
@ayeletstarkware ayeletstarkware changed the base branch from ayelet/mempool/fifo/impl-fifo-integrate-in-mempool to graphite-base/13081 March 10, 2026 09:05
@ayeletstarkware ayeletstarkware force-pushed the ayelet/mempool/fifo/rename-get-timestamp branch from f907010 to 5097077 Compare March 10, 2026 09:05
@ayeletstarkware ayeletstarkware changed the base branch from graphite-base/13081 to main-v0.14.2 March 10, 2026 09:05
@ayeletstarkware ayeletstarkware changed the base branch from main-v0.14.2 to main March 11, 2026 09:20
@ayeletstarkware ayeletstarkware changed the base branch from main to graphite-base/13081 March 11, 2026 09:34
@ayeletstarkware ayeletstarkware force-pushed the ayelet/mempool/fifo/rename-get-timestamp branch from 5097077 to 868331c Compare March 11, 2026 09:34
@ayeletstarkware ayeletstarkware changed the base branch from graphite-base/13081 to main-v0.14.2 March 11, 2026 09:34
@github-actions
Copy link

Artifacts upload workflows:

@ayeletstarkware ayeletstarkware changed the base branch from main-v0.14.2 to main March 11, 2026 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants