apollo_mempool: rename get_timestamp functions#13081
Closed
ayeletstarkware wants to merge 1 commit intomainfrom
Closed
apollo_mempool: rename get_timestamp functions#13081ayeletstarkware wants to merge 1 commit intomainfrom
ayeletstarkware wants to merge 1 commit intomainfrom
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
1f06daa to
b0b64d4
Compare
015a420 to
f907010
Compare
f907010 to
5097077
Compare
a25506f to
78551e8
Compare
5097077 to
868331c
Compare
|
Artifacts upload workflows: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Medium risk: changes touch consensus vote handling and stream buffering/eviction logic, plus batcher proposal-finalization and L1 event plumbing, which could affect liveness if edge cases are missed. CI workflow gating was also removed, potentially increasing PR load and changing when benchmarks run.
Overview
This PR replaces
apollo_l1_providerusage with a newapollo_l1_eventsprovider across the workspace (new crates added, dependencies updated, andnextestserialized filters switched), and updates batcher metrics/error types accordingly.It refactors batcher proposal validation finalization by removing
Finish/AbortfromSendProposalContentand introducing explicitfinish_proposal/abort_proposalrequests/responses (FinishProposalStatus), plus renames timestamp retrieval toget_batch_timestampbacked by mempool’sresolve_batch_timestamp.On the consensus side, it deduplicates cached future votes and reports peers on equivocation, and reworks the stream handler’s inbound LRU from a single
(peer, stream)cache to a two-level per-peer cache with new eviction behavior and tests. Separately, storage reader server spawning is updated to use the newspawn()API and always keep an abort handle alive.CI workflows drop the Graphite
optimize_cijob and related skip conditions, causing jobs (including benchmarks) to run unconditionally when their existing event/title guards allow.Written by Cursor Bugbot for commit 868331c. This will update automatically on new commits. Configure here.