Skip to content

apollo_mempool: add block number to data fetched from echonet#13119

Closed
ayeletstarkware wants to merge 1 commit intoayelet/mempool/fifo/rename-get-timestampfrom
ayelet/mempool/fifo/update-tx-block-metadata
Closed

apollo_mempool: add block number to data fetched from echonet#13119
ayeletstarkware wants to merge 1 commit intoayelet/mempool/fifo/rename-get-timestampfrom
ayelet/mempool/fifo/update-tx-block-metadata

Conversation

@ayeletstarkware
Copy link
Contributor

@ayeletstarkware ayeletstarkware commented Mar 10, 2026

Note

Medium Risk
Changes Echonet/FIFO transaction ingestion to depend on a new recorder endpoint and to store additional per-tx metadata, which can affect whether transactions are accepted and how they are tracked in the queue. Risk is moderate due to network/serialization changes and new required metadata plumbing, but limited to Echonet mode.

Overview
In Echonet (FIFO) mode, the mempool now fetches transaction block metadata (timestamp and block number) from the recorder via a new echonet/get_tx_block_metadata endpoint, and updates internal state before admitting the transaction.

This replaces the previous timestamp-only flow by plumbing block number through MempoolCommunicationWrapper, Mempool::update_tx_block_metadata, and the FIFO queue’s pending data, and updates integration/unit tests accordingly (including a mock recorder response format).

Written by Cursor Bugbot for commit 2b4e371. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

@ayeletstarkware ayeletstarkware marked this pull request as ready for review March 10, 2026 09:07
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

@ayeletstarkware ayeletstarkware force-pushed the ayelet/mempool/fifo/rename-get-timestamp branch from 5097077 to 868331c Compare March 11, 2026 09:34
@ayeletstarkware ayeletstarkware force-pushed the ayelet/mempool/fifo/update-tx-block-metadata branch from a9047a6 to 2b4e371 Compare March 11, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants