apollo_mempool: add block number to data fetched from echonet#13119
Closed
ayeletstarkware wants to merge 1 commit intoayelet/mempool/fifo/rename-get-timestampfrom
Closed
apollo_mempool: add block number to data fetched from echonet#13119ayeletstarkware wants to merge 1 commit intoayelet/mempool/fifo/rename-get-timestampfrom
ayeletstarkware wants to merge 1 commit intoayelet/mempool/fifo/rename-get-timestampfrom
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Mar 10, 2026
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
5097077 to
868331c
Compare
a9047a6 to
2b4e371
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Medium Risk
Changes Echonet/FIFO transaction ingestion to depend on a new recorder endpoint and to store additional per-tx metadata, which can affect whether transactions are accepted and how they are tracked in the queue. Risk is moderate due to network/serialization changes and new required metadata plumbing, but limited to Echonet mode.
Overview
In Echonet (FIFO) mode, the mempool now fetches transaction block metadata (timestamp and block number) from the recorder via a new
echonet/get_tx_block_metadataendpoint, and updates internal state before admitting the transaction.This replaces the previous timestamp-only flow by plumbing block number through
MempoolCommunicationWrapper,Mempool::update_tx_block_metadata, and the FIFO queue’s pending data, and updates integration/unit tests accordingly (including a mock recorder response format).Written by Cursor Bugbot for commit 2b4e371. This will update automatically on new commits. Configure here.