starknet_transaction_prover: add TLS integration tests

Cargo.toml

@@ -341,6 +341,7 @@ rand_distr = "0.4.3"
 reed-solomon-simd = "3.1.0"
 regex = "1.10.4"
 replace_with = "0.1.7"
+rcgen = "0.13"
 reqwest = "0.12"
 reqwest-middleware = "0.4.2"
 reqwest-retry = "0.7.0"

crates/starknet_transaction_prover/Cargo.toml

@@ -58,6 +58,7 @@ blockifier_test_utils.workspace = true
 jsonschema.workspace = true
 mockito.workspace = true
 privacy-circuit-verify.workspace = true
+rcgen.workspace = true
 reqwest.workspace = true
 rstest.workspace = true
 serde = { workspace = true, features = ["derive"] }

crates/starknet_transaction_prover/src/server/tls.rs

@@ -1,5 +1,9 @@
 //! TLS helpers for serving JSON-RPC over HTTPS.
 
+#[cfg(test)]
+#[path = "tls_test.rs"]
+mod tls_test;
+
 use std::net::SocketAddr;
 use std::path::Path;
 use std::sync::Arc;
@@ -115,7 +119,7 @@ pub async fn start_tls_server(
 }
 
 /// Loads a certificate chain and private key from PEM files and builds a TLS acceptor.
-fn load_tls_acceptor(cert_path: &Path, key_path: &Path) -> anyhow::Result<TlsAcceptor> {
+pub(crate) fn load_tls_acceptor(cert_path: &Path, key_path: &Path) -> anyhow::Result<TlsAcceptor> {
     let cert_pem = std::fs::read(cert_path)
         .with_context(|| format!("Failed to read TLS certificate file: {}", cert_path.display()))?;
     let cert_chain: Vec<CertificateDer<'static>> =

crates/starknet_transaction_prover/src/server/tls_test.rs

@@ -0,0 +1,132 @@
+use std::io::Write;
+use std::net::SocketAddr;
+
+use serde_json::Value;
+use tempfile::NamedTempFile;
+
+use crate::server::mock_rpc::MockProvingRpc;
+use crate::server::rpc_api::ProvingRpcServer;
+use crate::server::rpc_impl::SPEC_VERSION;
+use crate::server::tls::{load_tls_acceptor, start_tls_server};
+
+/// Installs the default rustls crypto provider (aws-lc-rs) if not already installed.
+/// Required by reqwest when using rustls-based TLS.
+fn ensure_crypto_provider() {
+    let _ = tokio_rustls::rustls::crypto::aws_lc_rs::default_provider().install_default();
+}
+
+/// Generates a self-signed certificate and private key using rcgen.
+/// Returns (cert_pem, key_pem) as byte vectors.
+fn generate_self_signed_cert() -> (Vec<u8>, Vec<u8>) {
+    let cert = rcgen::generate_simple_self_signed(vec!["localhost".to_string()])
+        .expect("Failed to generate self-signed certificate");
+    let cert_pem = cert.cert.pem().into_bytes();
+    let key_pem = cert.key_pair.serialize_pem().into_bytes();
+    (cert_pem, key_pem)
+}
+
+/// Writes PEM bytes to a temporary file and returns the handle.
+fn write_pem_to_tempfile(pem_bytes: &[u8]) -> NamedTempFile {
+    let mut file = NamedTempFile::new().expect("Failed to create temp file");
+    file.write_all(pem_bytes).expect("Failed to write PEM");
+    file.flush().expect("Failed to flush PEM file");
+    file
+}
+
+/// Starts a TLS server with mock RPC methods, returns (addr, server_handle, cert_pem).
+async fn start_test_tls_server() -> (SocketAddr, jsonrpsee::server::ServerHandle, Vec<u8>) {
+    let (cert_pem, key_pem) = generate_self_signed_cert();
+    let cert_file = write_pem_to_tempfile(&cert_pem);
+    let key_file = write_pem_to_tempfile(&key_pem);
+
+    let methods = MockProvingRpc::from_expected_json().into_rpc();
+    let addr: SocketAddr = "127.0.0.1:0".parse().unwrap();
+
+    let (local_addr, handle) = start_tls_server(
+        addr,
+        cert_file.path(),
+        key_file.path(),
+        methods,
+        10, // max_connections
+        None,
+    )
+    .await
+    .expect("Failed to start TLS server");
+
+    (local_addr, handle, cert_pem)
+}
+
+#[tokio::test]
+async fn test_https_spec_version_succeeds() {
+    ensure_crypto_provider();
+    let (addr, handle, cert_pem) = start_test_tls_server().await;
+
+    let cert = reqwest::tls::Certificate::from_pem(&cert_pem)
+        .expect("Failed to parse certificate for reqwest");
+    let client = reqwest::Client::builder()
+        .add_root_certificate(cert)
+        .build()
+        .expect("Failed to build HTTPS client");
+
+    let body = serde_json::json!({
+        "jsonrpc": "2.0",
+        "id": "1",
+        "method": "starknet_specVersion"
+    });
+
+    let response = client
+        .post(format!("https://localhost:{}", addr.port()))
+        .json(&body)
+        .send()
+        .await
+        .expect("HTTPS request failed");
+
+    assert_eq!(response.status(), 200);
+
+    let json: Value = response.json().await.expect("Failed to parse response JSON");
+    assert_eq!(json["result"].as_str().unwrap(), SPEC_VERSION);
+
+    handle.stop().expect("Failed to stop server");
+}
+
+#[tokio::test]
+async fn test_http_to_tls_server_fails() {
+    ensure_crypto_provider();
+    let (addr, handle, _cert_pem) = start_test_tls_server().await;
+
+    let client = reqwest::Client::new();
+    let body = serde_json::json!({
+        "jsonrpc": "2.0",
+        "id": "1",
+        "method": "starknet_specVersion"
+    });
+
+    // Plain HTTP to a TLS server should fail (connection or protocol error).
+    let result = client.post(format!("http://localhost:{}", addr.port())).json(&body).send().await;
+
+    assert!(result.is_err(), "Expected HTTP to TLS server to fail, but got: {result:?}");
+
+    handle.stop().expect("Failed to stop server");
+}
+
+#[test]
+fn test_load_tls_acceptor_missing_cert_file() {
+    let key_file = write_pem_to_tempfile(b"dummy key content");
+    let result = load_tls_acceptor("/nonexistent/cert.pem".as_ref(), key_file.path());
+    assert!(result.is_err(), "Expected error for missing cert file");
+}
+
+#[test]
+fn test_load_tls_acceptor_missing_key_file() {
+    let cert_file = write_pem_to_tempfile(b"dummy cert content");
+    let result = load_tls_acceptor(cert_file.path(), "/nonexistent/key.pem".as_ref());
+    assert!(result.is_err(), "Expected error for missing key file");
+}
+
+#[test]
+fn test_load_tls_acceptor_invalid_pem() {
+    let cert_file = write_pem_to_tempfile(b"not a valid PEM certificate");
+    let key_file = write_pem_to_tempfile(b"not a valid PEM key");
+    let result = load_tls_acceptor(cert_file.path(), key_file.path());
+    assert!(result.is_err(), "Expected error for invalid PEM content");
+}