starknet_transaction_prover: add TLS integration tests#13138
Open
avi-starkware wants to merge 1 commit intoavi/privacy/cors-and-config-testsfrom
Open
starknet_transaction_prover: add TLS integration tests#13138avi-starkware wants to merge 1 commit intoavi/privacy/cors-and-config-testsfrom
avi-starkware wants to merge 1 commit intoavi/privacy/cors-and-config-testsfrom
Conversation
ae8f388 to
cf88612
Compare
673d9c3 to
50f4fea
Compare
This was referenced Mar 10, 2026
Collaborator
Author
2 tasks
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
50f4fea to
3714254
Compare
cf88612 to
1091461
Compare
fe7020f to
d3a6339
Compare
1091461 to
6235e80
Compare
d3a6339 to
c63f0d5
Compare
6235e80 to
6a944e0
Compare
c63f0d5 to
e2796ec
Compare
1eade72 to
662669a
Compare
e2796ec to
61d038d
Compare
662669a to
783e4ce
Compare
61d038d to
1ef94b1
Compare
783e4ce to
a8827f8
Compare
1ef94b1 to
2e8b350
Compare
This was referenced Mar 10, 2026
a8827f8 to
49a3322
Compare
2e8b350 to
42fbe3b
Compare
49a3322 to
f479105
Compare
42fbe3b to
d085339
Compare
f479105 to
cf86175
Compare
d085339 to
1ad788f
Compare
cf86175 to
ce8a83d
Compare
1ad788f to
dfa96ea
Compare
4 tasks
ce8a83d to
8453086
Compare
58223bb to
ec86e42
Compare
8453086 to
8517456
Compare
Add 5 tests for the TLS server module: - HTTPS request succeeds with self-signed cert (specVersion) - Plain HTTP to TLS server fails (protocol mismatch) - Missing cert/key file produces error - Invalid PEM content produces error Uses rcgen (new workspace dev-dep) to generate self-signed certs at test time, avoiding committed certificate fixtures that expire. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
8517456 to
8155738
Compare
ec86e42 to
6b00901
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
rcgen(new workspace dev-dependency) to generate self-signed certs at test time, avoiding committed fixtures that expireload_tls_acceptorpub(crate)for unit-level testingTest plan
SEED=0 cargo test -p starknet_transaction_prover -- tls_test— 5 tests passSEED=0 cargo test -p starknet_transaction_prover --lib— 103 pass, 0 fail, 6 ignored🤖 Generated with Claude Code
Note
Low Risk
Low risk: changes are test-only plus a minor visibility tweak (
pub(crate)) with no production logic changes.Overview
Adds a new
tls_test.rssuite that spins up the JSON-RPC server over HTTPS with a self-signed certificate and validates both success (HTTPSstarknet_specVersion) and failure modes (HTTP-to-TLS, missing cert/key files, invalid PEM).Introduces
rcgenas a (dev) dependency to generate certificates at test time, and makesload_tls_acceptorpub(crate)so it can be unit-tested.Written by Cursor Bugbot for commit 6b00901. This will update automatically on new commits. Configure here.