starknet_transaction_prover: add ConfigMap docs and full config reference#13167
Open
avi-starkware wants to merge 1 commit intoavi/privacy/external-dev-experiencefrom
Open
starknet_transaction_prover: add ConfigMap docs and full config reference#13167avi-starkware wants to merge 1 commit intoavi/privacy/external-dev-experiencefrom
avi-starkware wants to merge 1 commit intoavi/privacy/external-dev-experiencefrom
Conversation
This was referenced Mar 11, 2026
Collaborator
Author
85947e7 to
bd51ae4
Compare
bd51ae4 to
dcb7da6
Compare
…e, remove bouncer CLI override Add Kubernetes ConfigMap deployment guide, document the full nested JSON config structure (bouncer_config, storage_proof_config, contract_class_manager_config), expand example-config.json to show all fields, and remove the --bouncer-config-override CLI arg / env var since the config file now covers this. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
dcb7da6 to
bf5bdd5
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
| transport, | ||
| }) | ||
| }; | ||
| info!("Effective configuration: {:#?}", service_config); |
There was a problem hiding this comment.
Startup logging may expose sensitive RPC API keys
Low Severity
The new info!("Effective configuration: {:#?}", service_config) unconditionally logs the entire ServiceConfig at startup, including prover_config.rpc_node_url. RPC URLs commonly embed API keys (e.g. https://mainnet.infura.io/v3/SECRET_KEY). Previously, the URL was only logged when a CLI override changed it; now it's always emitted to the info log level regardless of how it was configured.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
bouncer_config,storage_proof_config,contract_class_manager_config)resources/example-config.jsonto show the complete config structure with all nested fields--bouncer-config-overrideCLI arg andBOUNCER_CONFIG_OVERRIDEenv var — the JSON config file now covers this use caseTest plan
cargo check -p starknet_transaction_proverpassescargo test -p starknet_transaction_prover)example-config.jsonvalidates as valid JSONStacked on #13158 (
avi/privacy/external-dev-experience)🤖 Generated with Claude Code
Note
Medium Risk
Mostly documentation/config reference updates, but it removes the
--bouncer-config-override/BOUNCER_CONFIG_OVERRIDEpath, which could break existing deployments relying on that override mechanism.Overview
Adds a full JSON configuration reference to the
starknet_transaction_proverREADME (including detailedbouncer_configstructure) and new Kubernetes deployment guidance using a ConfigMap, plus explicit configuration precedence rules.Expands
resources/example-config.jsonto include the complete nested config structure (runner/storage proof, executor/bouncer limits & weights, and contract class manager/native compiler settings). Removes the--bouncer-config-overrideCLI/env override path insrc/server/config.rsand updates tests accordingly, and logs the effective resolvedServiceConfigat startup.Written by Cursor Bugbot for commit bf5bdd5. This will update automatically on new commits. Configure here.