starknet_transaction_prover: add prover input validation unit tests#13133
Open
avi-starkware wants to merge 1 commit intoavi/privacy/error-sanitizationfrom
Open
starknet_transaction_prover: add prover input validation unit tests#13133avi-starkware wants to merge 1 commit intoavi/privacy/error-sanitizationfrom
avi-starkware wants to merge 1 commit intoavi/privacy/error-sanitizationfrom
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
crates/starknet_transaction_prover/src/proving/virtual_snos_prover_test.rs
Show resolved
Hide resolved
7f5be1c to
db1cf67
Compare
This was referenced Mar 10, 2026
Collaborator
Author
This was referenced Mar 10, 2026
43d4c74 to
ee5e11d
Compare
7982e54 to
b748325
Compare
ee5e11d to
4bda7e3
Compare
b748325 to
79d53a0
Compare
02d25e3 to
5225da0
Compare
79d53a0 to
74372d3
Compare
5225da0 to
e6f2c6f
Compare
74372d3 to
8ad5806
Compare
e6f2c6f to
f7e548f
Compare
d60783c to
f370546
Compare
f7e548f to
87684b7
Compare
This was referenced Mar 10, 2026
87684b7 to
5967250
Compare
f370546 to
a0eca5b
Compare
5967250 to
e1bf622
Compare
a0eca5b to
6848848
Compare
e1bf622 to
872a9ae
Compare
6848848 to
8440f7b
Compare
872a9ae to
f2904ac
Compare
8440f7b to
b174fa7
Compare
4 tasks
b174fa7 to
ae858d3
Compare
f2904ac to
21a9f20
Compare
ae858d3 to
7d0dc27
Compare
21a9f20 to
55dc3f7
Compare
Add 7 unit tests for validate_transaction_input covering pending block rejection, non-invoke transaction types, proof/proof_facts fields, fee field enforcement, and fee validation toggle. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
55dc3f7 to
9e21cc4
Compare
7d0dc27 to
0fca6ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
validate_transaction_input: pending block rejection, non-invoke transaction types, proof/proof_facts field checks, fee field enforcement, and fee validation togglewith_fee_validationbuilder method onVirtualSnosProverTest plan
SEED=0 cargo test -p starknet_transaction_prover -- virtual_snos_prover_test— 7 pass, 2 ignored (integration)🤖 Generated with Claude Code
Note
Low Risk
Low risk because changes are test-only plus a test-time toggle for fee-field validation; no production proving logic is modified beyond how tests construct the prover.
Overview
Adds a focused set of unit tests around
VirtualSnosProver::prove_transactioninput validation (rejectsPendingblock IDs, non-InvokeV3tx types, non-emptyproof/proof_facts, and non-zero fee-related fields when validation is enabled).Introduces lightweight mock runners (
UnreachableRunner,FailingRunner) to assert whether validation short-circuits before OS execution, and updates the ignored Sepolia integration tests to call.disable_fee_validation()so they exercise the full pipeline without fee-field constraints.Written by Cursor Bugbot for commit 0fca6ef. This will update automatically on new commits. Configure here.