feat(starknet_batcher): state reader get compiled classes from class manager

[noamsp-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[noamsp-starkware]

• feat(starknet_batcher): state reader get compiled classes from class manager #3676 👈 (View in Graphite)
• feat(starknet_gateway): state reader get compiled classes from class manager #3578
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Artifacts upload workflows:

• Started at 2025-01-26T12:50:07Z
• Started at 2025-01-26T14:30:26Z
• Started at 2025-01-26T14:33:37Z
• Started at 2025-01-26T15:05:06Z
• Started at 2025-01-27T10:21:34Z

[ShahakShama]

@alonh5 or someone else from your team, please review this :)

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @noamsp-starkware)

---

crates/papyrus_state_reader/src/papyrus_state_wrapper.rs line 15 at r1 (raw file):

use crate::papyrus_state::PapyrusReader;
pub struct PapyrusReaderWrapper {

Rename to PapyrusReaderWithClassManager

---

crates/papyrus_state_reader/src/lib.rs line 2 at r1 (raw file):

pub mod papyrus_state;
pub mod papyrus_state_wrapper;

Move this file to the batcher

[ShahakShama]

Reviewed 8 of 8 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noamsp-starkware)

---

crates/starknet_batcher/src/papyrus_state_wrapper.rs line 15 at r2 (raw file):

use starknet_types_core::felt::Felt;
pub struct PapyrusReaderWithClassManager {
    papyrus_reader: PapyrusReader,

Change this into a generic StateReader and in the tests use MockStateReader. Rename the struct to ReaderWithClassManager and rename the file accordingly

[noamsp-starkware]

Reviewable status: 4 of 11 files reviewed, 1 unresolved discussion (waiting on @ShahakShama)

---

crates/starknet_batcher/src/papyrus_state_wrapper.rs line 15 at r2 (raw file):

Previously, ShahakShama wrote…

Change this into a generic StateReader and in the tests use MockStateReader. Rename the struct to ReaderWithClassManager and rename the file accordingly

Done.

[ShahakShama]

Reviewed 7 of 7 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @noamsp-starkware)

---

crates/blockifier/src/state/state_api.rs line 24 at r3 (raw file):

/// The `self` argument is mutable for flexibility during reads (for example, caching reads),
/// and to allow for the `State` trait below to also be considered a `StateReader`.
#[cfg_attr(feature = "testing", automock)]

@dorimedini-starkware please approve this change

---

crates/starknet_batcher/src/reader_with_class_manager_test.rs line 14 at r3 (raw file):

#[tokio::test]
async fn test_get_compiled_class() {

In a different PR, create a test for each of the other methods to make sure that you pass the call to the inner state reader

[dorimedini-starkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @noamsp-starkware and @ShahakShama)

---

crates/blockifier/src/state/state_api.rs line 24 at r3 (raw file):

Previously, ShahakShama wrote…

@dorimedini-starkware please approve this change

1. what is automock?
2. consider using mockall::automock so you don't need the extra gated use at the top
3. if you gate code behind feature = "testing" and not test, then that means your crate tests do not use this and it is only a test util for external use (we will be disallowing crates depending on self with the testing feature activated - we want no dependency cycles). If it is also used for internal testing please use #[cfg_attr(any(test, feature = "testing"), automock)]

[ShahakShama]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @noamsp-starkware)

---

crates/blockifier/src/state/state_api.rs line 24 at r3 (raw file):

Previously, dorimedini-starkware wrote…

1. what is automock?
2. consider using mockall::automock so you don't need the extra gated use at the top
3. if you gate code behind feature = "testing" and not test, then that means your crate tests do not use this and it is only a test util for external use (we will be disallowing crates depending on self with the testing feature activated - we want no dependency cycles). If it is also used for internal testing please use #[cfg_attr(any(test, feature = "testing"), automock)]

1. It creates a struct called Mock* where * is name of trait that for each function in the trait annotated as foo it has a function called expect_foo that tells what to return when someone calls foo
2. Good idea
3. I agree. @noamsp-starkware please make this change

[noamsp-starkware]

Reviewable status: 5 of 12 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware and @ShahakShama)

---

crates/starknet_batcher/src/reader_with_class_manager_test.rs line 14 at r3 (raw file):

Previously, ShahakShama wrote…

In a different PR, create a test for each of the other methods to make sure that you pass the call to the inner state reader

Added a TODO for this.

[ShahakShama]

Reviewed 7 of 7 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware)