feat(starknet_gateway): state reader get compiled classes from class manager#3578
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
103367c to
78fb37d
Compare
78fb37d to
4f7fe17
Compare
4921fbd to
1989395
Compare
c866daf to
b8fde03
Compare
1989395 to
6f01955
Compare
b8fde03 to
a001ab3
Compare
6f01955 to
4870e47
Compare
ShahakShama
left a comment
There was a problem hiding this comment.
Reviewed 1 of 6 files at r1, 4 of 5 files at r2, 65 of 65 files at r3.
Reviewable status: 70 of 72 files reviewed, all discussions resolved
ShahakShama
left a comment
There was a problem hiding this comment.
Reviewed 1 of 6 files at r1, 1 of 5 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @noamsp-starkware)
a discussion (no related file):
@alonh5 should also review this
crates/starknet_gateway/src/sync_state_reader.rs line 115 at r3 (raw file):
Ok(value) => value, // TODO(noamsp): Remove this once the class manager component is ready. Err(ClassManagerClientError::ClassManagerError(
After talking with @alonh5, because we currently use EmptyClassManagerClient which returns default(), we should do this not when we receive a ClassNotFound, but when we receive Ok(default())
a001ab3 to
6590c16
Compare
4870e47 to
8ec4b4b
Compare
noamsp-starkware
left a comment
There was a problem hiding this comment.
Reviewable status: 7 of 72 files reviewed, 2 unresolved discussions (waiting on @alonh5 and @ShahakShama)
crates/starknet_gateway/src/sync_state_reader.rs line 115 at r3 (raw file):
Previously, ShahakShama wrote…
After talking with @alonh5, because we currently use EmptyClassManagerClient which returns default(), we should do this not when we receive a ClassNotFound, but when we receive Ok(default())
Done.
3d1bacb to
4828d7f
Compare
8ec4b4b to
48df8d1
Compare
4828d7f to
6cda1dc
Compare
48df8d1 to
a294a76
Compare
ShahakShama
left a comment
There was a problem hiding this comment.
Reviewed 65 of 65 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noamsp-starkware)
6cda1dc to
534dbda
Compare
a294a76 to
baec399
Compare
|
Artifacts upload workflows: |
69749db to
f3f6070
Compare
baec399 to
e07c01d
Compare
8f3af62 to
8c34d6b
Compare
e07c01d to
1e797f4
Compare
ShahakShama
left a comment
There was a problem hiding this comment.
Reviewed 24 of 24 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noamsp-starkware)
alonh5
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noamsp-starkware)

No description provided.