feat(starknet_mempool): add TransactionReference new from InternalRpcTransaction#3502
Merged
Conversation
This was referenced Jan 20, 2025
Merged
|
This change is |
This was referenced Jan 20, 2025
Contributor
Author
This was referenced Jan 20, 2025
feat(starknet_batcher): use transaction converter to infer executable from mempool internal tx
#3509
Merged
noamsp-starkware
force-pushed
the
noam.s/feat_starknet_api_add_getters_for_InternalRpcTransaction
branch
from
06a1d50 to
c9c39e4
Compare
noamsp-starkware
force-pushed
the
noam.s/feat_starknet_mempool_add_TransactionReference_new_from_InteralRpcTransaction
branch
from
58993e1 to
e9a2da5
Compare
noamsp-starkware
force-pushed
the
noam.s/feat_starknet_api_add_getters_for_InternalRpcTransaction
branch
from
c9c39e4 to
20dcfb7
Compare
noamsp-starkware
force-pushed
the
noam.s/feat_starknet_mempool_add_TransactionReference_new_from_InteralRpcTransaction
branch
from
e9a2da5 to
835245d
Compare
ShahakShama
approved these changes
Jan 21, 2025
Collaborator
ShahakShama
left a comment
ShahakShama
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware)
noamsp-starkware
force-pushed
the
noam.s/feat_starknet_api_add_getters_for_InternalRpcTransaction
branch
from
20dcfb7 to
200e9a5
Compare
noamsp-starkware
force-pushed
the
noam.s/feat_starknet_mempool_add_TransactionReference_new_from_InteralRpcTransaction
branch
from
835245d to
f4bc18e
Compare
noamsp-starkware
force-pushed
the
noam.s/feat_starknet_api_add_getters_for_InternalRpcTransaction
branch
from
200e9a5 to
bdd01b4
Compare
noamsp-starkware
force-pushed
the
noam.s/feat_starknet_mempool_add_TransactionReference_new_from_InteralRpcTransaction
branch
from
f4bc18e to
cb32339
Compare
This was referenced Jan 21, 2025
noamsp-starkware
merged commit 4ec0aae
into
noam.s/feat_starknet_api_add_getters_for_InternalRpcTransaction
13 of 17 checks passed
|
Artifacts upload workflows: |
noamsp-starkware
deleted the
noam.s/feat_starknet_mempool_add_TransactionReference_new_from_InteralRpcTransaction
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.