feat(starknet_gateway): add class manager client

[noamsp-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[noamsp-starkware]

• feat(starknet_gateway): add class manager client #3497 : 4 dependent PRs (#3498 , #3578 , #3581 and 1 other) 👈 (View in Graphite)
• fix(starknet_gateway): remove compiled_class_hash_mismatch test #3609
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[ShahakShama]

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noamsp-starkware)

---

crates/starknet_gateway/bench/utils.rs line 90 at r1 (raw file):

            GatewayCompiler::new_command_line_compiler(config.compiler_config.clone());
        let mut mempool_client = MockMempoolClient::new();
        let class_manager_client = Arc::new(MemoryClassManagerClient::new());

I think you should use EmptyClassManagerClient here. @alonh5 WDYT?

[noamsp-starkware]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alonh5)

---

crates/starknet_gateway/bench/utils.rs line 90 at r1 (raw file):

Previously, ShahakShama wrote…

I think you should use EmptyClassManagerClient here. @alonh5 WDYT?

I didn't use the Empty variant because this is a test

[github-actions]

Artifacts upload workflows:

• Started at 2025-01-20T14:18:48Z
• Started at 2025-01-20T15:34:09Z
• Started at 2025-01-21T05:34:26Z
• Started at 2025-01-21T12:52:05Z
• Started at 2025-01-21T15:33:13Z
• Started at 2025-01-22T10:47:38Z
• Started at 2025-01-22T11:04:58Z
• Started at 2025-01-22T11:14:19Z
• Started at 2025-01-22T11:24:45Z
• Started at 2025-01-22T12:19:18Z
• Started at 2025-01-22T12:21:00Z
• Started at 2025-01-22T12:21:41Z
• Started at 2025-01-22T15:42:39Z
• Started at 2025-01-23T09:46:20Z
• Started at 2025-01-23T09:49:19Z
• Started at 2025-01-23T11:04:18Z
• Started at 2025-01-26T08:23:40Z
• Started at 2025-01-26T08:29:52Z

[ShahakShama]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alonh5)

---

crates/starknet_gateway/bench/utils.rs line 90 at r1 (raw file):

Previously, noamsp-starkware wrote…

I didn't use the Empty variant because this is a test

After the discussion with Elin you should change to Empty

[noamsp-starkware]

Reviewable status: 3 of 6 files reviewed, 1 unresolved discussion (waiting on @alonh5 and @ShahakShama)

---

crates/starknet_gateway/bench/utils.rs line 90 at r1 (raw file):

Previously, ShahakShama wrote…

After the discussion with Elin you should change to Empty

Done.

[ShahakShama]

Reviewed 5 of 5 files at r4, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @noamsp-starkware)

---

crates/starknet_gateway/src/gateway_test.rs line 63 at r4 (raw file):

) -> MockDependencies {
    let mock_mempool_client = MockMempoolClient::new();
    // TODO(noamsp): use MockClassManagerClient

Same here

---

crates/starknet_gateway/bench/utils.rs line 90 at r4 (raw file):

            GatewayCompiler::new_command_line_compiler(config.compiler_config.clone());
        let mut mempool_client = MockMempoolClient::new();
        // TODO(noamsp): use MockClassManagerClient

Change the TODO to "use MockTransactionConverter"

[ArniStarkware]

crates/starknet_sequencer_node/src/components.rs line 87 at r17 (raw file):

                .get_state_sync_shared_client()
                .expect("State Sync Client should be available");
            // TODO: Remove this and use the real client instead once implemented.

Please put it on your name, and ask for help later.
This code is intended for production (vs test).

Suggestion:

// TODO(NoamS):

[github-actions]

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [35.262 ms 35.746 ms 36.307 ms]
change: [+2.5342% +3.9862% +5.7497%] (p = 0.00 < 0.05)
Performance has regressed.
Found 9 outliers among 100 measurements (9.00%)
2 (2.00%) high mild
7 (7.00%) high severe

[ShahakShama]

Reviewed 249 of 249 files at r27, 3 of 61 files at r28, 1 of 246 files at r29, 5 of 62 files at r30, 49 of 246 files at r31, 62 of 62 files at r32, 1 of 245 files at r33, 1 of 57 files at r34, 13 of 266 files at r35, 13 of 257 files at r37, 12 of 72 files at r38, 4 of 62 files at r40, 10 of 239 files at r41, 9 of 66 files at r42, 2 of 225 files at r43, 225 of 225 files at r45.
Reviewable status: 75 of 358 files reviewed, 3 unresolved discussions (waiting on @ArniStarkware and @noamsp-starkware)

[ShahakShama]

Reviewed 1 of 62 files at r46, 5 of 65 files at r56, 2 of 216 files at r57, 1 of 58 files at r58, 8 of 65 files at r60, 7 of 206 files at r61, 60 of 61 files at r62, 199 of 199 files at r63, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @noamsp-starkware)

[ShahakShama]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @noamsp-starkware)

[ArniStarkware]

crates/starknet_api/src/rpc_transaction.rs line 56 at r26 (raw file):

Previously, ArniStarkware (Arnon Hod) wrote…

What do you think about this?
I like it better because RpcDeployAccountTransaction is a wrapper, not unique for version 3. If and when version 4 txs are added (or older version txs are supported - not probable, but still), the wrapper is still relevant.

Also - it better implies the fact that there is an unwrapping to be made to reach the V3 tx.

Non -blocking.

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.966 ms 35.009 ms 35.056 ms]
change: [-4.0471% -2.5487% -1.2503%] (p = 0.00 < 0.05)
Performance has improved.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high severe

[ShahakShama]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @noamsp-starkware)

[noamsp-starkware]

merged @ #3656