feat(starknet_mempool_p2p): add class manager to propogator

[noamsp-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[noamsp-starkware]

• feat(starknet_mempool): handle declare tx properly #3512
• refactor: align gateway and mempool tests with InternalRpcTx change #3511
• refactor: use InternalRpcTransaction in gateway and mempool #3510
• feat(starknet_batcher): use transaction converter to infer executable from mempool internal tx #3509
• feat(starknet_mempool): add TransactionReference new from InternalRpcTransaction #3502
• feat(starknet_api): add getters for InternalRpcTransaction #3501
• feat(starknet_mempool_p2p): add class manager to propogator #3500 👈 (View in Graphite)
• refactor(starknet_gateway): remove unused gateway compiler #3499
• feat(starknet_gateway): get executable tx from class manager #3498
• feat(starknet_gateway): add class manager client #3497 : 3 other dependent PRs (#3578 , #3581 , #3608 )
• fix(starknet_gateway): remove compiled_class_hash_mismatch test #3609
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.741 ms 34.762 ms 34.786 ms]
change: [-5.0857% -3.5345% -2.1608%] (p = 0.00 < 0.05)
Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
2 (2.00%) high mild
3 (3.00%) high severe

[github-actions]

Artifacts upload workflows:

• Started at 2025-01-20T14:19:16Z
• Started at 2025-01-21T05:34:49Z
• Started at 2025-01-21T12:52:27Z
• Started at 2025-01-21T15:33:36Z
• Started at 2025-01-22T10:46:57Z

[github-actions]

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [36.200 ms 36.883 ms 37.614 ms]
change: [+1.4169% +3.8615% +6.4798%] (p = 0.00 < 0.05)
Performance has regressed.
Found 14 outliers among 100 measurements (14.00%)
11 (11.00%) high mild
3 (3.00%) high severe

[ShahakShama]

Reviewed 2 of 6 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @noamsp-starkware)

---

crates/starknet_mempool_p2p/src/propagator/mod.rs line 20 at r2 (raw file):

    broadcast_topic_client: BroadcastTopicClient<RpcTransactionWrapper>,
    #[allow(dead_code)]
    transaction_converter: TransactionConverter,

As I wrote in wg slack, change to _transaction_converter and remove the allow dead code

---

crates/starknet_mempool_p2p/src/propagator/test.rs line 33 at r2 (raw file):

    let BroadcastNetworkMock { mut messages_to_broadcast_receiver, .. } = mock_network;
    let rpc_transaction = RpcTransaction::get_test_instance(&mut get_rng());
    // TODO(noamsp): use MockClassManagerClient

Change the TODO to "use MockTransactionConverterTrait"

---

crates/starknet_mempool_p2p/src/propagator/test.rs line 53 at r2 (raw file):

    let BroadcastNetworkMock { mut continue_propagation_receiver, .. } = mock_network;
    let propagation_metadata = BroadcastedMessageMetadata::get_test_instance(&mut get_rng());
    // TODO(noamsp): use MockClassManagerClient

Same here

[noamsp-starkware]

Reviewable status: 4 of 6 files reviewed, 3 unresolved discussions (waiting on @ShahakShama)

---

crates/starknet_mempool_p2p/src/propagator/mod.rs line 20 at r2 (raw file):

Previously, ShahakShama wrote…

As I wrote in wg slack, change to _transaction_converter and remove the allow dead code

Done.

---

crates/starknet_mempool_p2p/src/propagator/test.rs line 33 at r2 (raw file):

Previously, ShahakShama wrote…

Change the TODO to "use MockTransactionConverterTrait"

Done.

---

crates/starknet_mempool_p2p/src/propagator/test.rs line 53 at r2 (raw file):

Previously, ShahakShama wrote…

Same here

Done.

[ShahakShama]

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware)

[ShahakShama]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware)