feat(starknet_mempool): handle declare tx properly#3512
Merged
noamsp-starkware merged 1 commit intonoam.s/refactor_align_gateway_and_mempool_tests_with_InternalRpcTx_changefrom Jan 22, 2025
Conversation
|
This change is |
This was referenced Jan 20, 2025
feat(starknet_batcher): use transaction converter to infer executable from mempool internal tx
#3509
Merged
Contributor
Author
noamsp-starkware
force-pushed
the
noam.s/refactor_align_gateway_and_mempool_tests_with_InternalRpcTx_change
branch
from
773890b to
9282c2c
Compare
noamsp-starkware
force-pushed
the
noam.s/feat_starknet_mempool_handle_declare_tx_properly
branch
from
5f03d7d to
04304d7
Compare
noamsp-starkware
force-pushed
the
noam.s/refactor_align_gateway_and_mempool_tests_with_InternalRpcTx_change
branch
from
9282c2c to
47569c1
Compare
noamsp-starkware
force-pushed
the
noam.s/feat_starknet_mempool_handle_declare_tx_properly
branch
from
04304d7 to
c3aa82d
Compare
noamsp-starkware
force-pushed
the
noam.s/refactor_align_gateway_and_mempool_tests_with_InternalRpcTx_change
branch
from
47569c1 to
b4f5f15
Compare
noamsp-starkware
force-pushed
the
noam.s/feat_starknet_mempool_handle_declare_tx_properly
branch
from
c3aa82d to
bed49fe
Compare
ShahakShama
approved these changes
Jan 21, 2025
Collaborator
ShahakShama
left a comment
ShahakShama
left a comment
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware)
noamsp-starkware
force-pushed
the
noam.s/refactor_align_gateway_and_mempool_tests_with_InternalRpcTx_change
branch
from
b4f5f15 to
a759c0f
Compare
noamsp-starkware
force-pushed
the
noam.s/feat_starknet_mempool_handle_declare_tx_properly
branch
from
bed49fe to
071a24b
Compare
This was referenced Jan 21, 2025
noamsp-starkware
merged commit 4c99325
into
noam.s/refactor_align_gateway_and_mempool_tests_with_InternalRpcTx_change
4 of 7 checks passed
noamsp-starkware
deleted the
noam.s/feat_starknet_mempool_handle_declare_tx_properly
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.