Skip to content

feat(starknet_api): add getters for InternalRpcTransaction#3501

Merged
noamsp-starkware merged 6 commits intonoam.s/feat_starknet_mempool_p2p_add_class_manager_to_propogatorfrom
noam.s/feat_starknet_api_add_getters_for_InternalRpcTransaction
Jan 22, 2025
Merged

feat(starknet_api): add getters for InternalRpcTransaction#3501
noamsp-starkware merged 6 commits intonoam.s/feat_starknet_mempool_p2p_add_class_manager_to_propogatorfrom
noam.s/feat_starknet_api_add_getters_for_InternalRpcTransaction

Conversation

@noamsp-starkware
Copy link
Contributor

@noamsp-starkware noamsp-starkware commented Jan 20, 2025

No description provided.

This was referenced Jan 20, 2025
Merged
Merged
Closed
@reviewable-StarkWare
Copy link

reviewable-StarkWare commented Jan 20, 2025

This change is Reviewable

This was referenced Jan 20, 2025
Merged
Merged
Merged
@noamsp-starkware Graphite App
Copy link
Contributor Author

noamsp-starkware commented Jan 20, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@noamsp-starkware noamsp-starkware mentioned this pull request Jan 20, 2025
Merged
@noamsp-starkware noamsp-starkware marked this pull request as ready for review January 20, 2025 09:37
@github-actions
Copy link

github-actions bot commented Jan 20, 2025

Benchmark movements:
tree_computation_flow performance improved 😺
tree_computation_flow time: [34.731 ms 34.767 ms 34.814 ms]
change: [-4.2701% -2.8101% -1.5597%] (p = 0.00 < 0.05)
Performance has improved.
Found 6 outliers among 100 measurements (6.00%)
2 (2.00%) high mild
4 (4.00%) high severe

This was referenced Jan 20, 2025
Merged
Merged
Merged
Merged
@noamsp-starkware noamsp-starkware force-pushed the noam.s/feat_starknet_mempool_p2p_add_class_manager_to_propogator branch from 38b29f2 to 54a9e74 Compare January 20, 2025 14:19
@noamsp-starkware noamsp-starkware force-pushed the noam.s/feat_starknet_api_add_getters_for_InternalRpcTransaction branch from 06a1d50 to c9c39e4 Compare January 20, 2025 14:19
@github-actions
Copy link

github-actions bot commented Jan 20, 2025

Benchmark movements:
tree_computation_flow performance regressed!
tree_computation_flow time: [35.112 ms 35.598 ms 36.167 ms]
change: [+1.5443% +2.8783% +4.7458%] (p = 0.00 < 0.05)
Performance has regressed.
Found 18 outliers among 100 measurements (18.00%)
2 (2.00%) low severe
1 (1.00%) low mild
4 (4.00%) high mild
11 (11.00%) high severe

@noamsp-starkware noamsp-starkware force-pushed the noam.s/feat_starknet_mempool_p2p_add_class_manager_to_propogator branch from 54a9e74 to ffa9b3e Compare January 21, 2025 05:34
@noamsp-starkware noamsp-starkware force-pushed the noam.s/feat_starknet_api_add_getters_for_InternalRpcTransaction branch from c9c39e4 to 20dcfb7 Compare January 21, 2025 05:34
ShahakShama
ShahakShama approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware)

@noamsp-starkware noamsp-starkware force-pushed the noam.s/feat_starknet_mempool_p2p_add_class_manager_to_propogator branch from ffa9b3e to 541ae00 Compare January 21, 2025 12:52
@noamsp-starkware noamsp-starkware force-pushed the noam.s/feat_starknet_api_add_getters_for_InternalRpcTransaction branch from 20dcfb7 to 200e9a5 Compare January 21, 2025 12:52
@noamsp-starkware noamsp-starkware force-pushed the noam.s/feat_starknet_mempool_p2p_add_class_manager_to_propogator branch from 541ae00 to a32d284 Compare January 21, 2025 15:33
@noamsp-starkware noamsp-starkware force-pushed the noam.s/feat_starknet_api_add_getters_for_InternalRpcTransaction branch from 200e9a5 to bdd01b4 Compare January 21, 2025 15:33
This was referenced Jan 21, 2025
Merged
Closed
@noamsp-starkware noamsp-starkware merged commit 91b2e3e into noam.s/feat_starknet_mempool_p2p_add_class_manager_to_propogator Jan 22, 2025
13 of 17 checks passed
@github-actions
Copy link

github-actions bot commented Jan 22, 2025

Artifacts upload workflows:

@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2025
@noamsp-starkware noamsp-starkware deleted the noam.s/feat_starknet_api_add_getters_for_InternalRpcTransaction branch January 27, 2025 11:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ShahakShama ShahakShama ShahakShama approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@noamsp-starkware @reviewable-StarkWare @ShahakShama