feat(starknet_batcher): use transaction converter to infer executable from mempool internal tx

[noamsp-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[noamsp-starkware]

• feat(starknet_mempool): handle declare tx properly #3512
• refactor: align gateway and mempool tests with InternalRpcTx change #3511
• refactor: use InternalRpcTransaction in gateway and mempool #3510
• feat(starknet_batcher): use transaction converter to infer executable from mempool internal tx #3509 👈 (View in Graphite)
• feat(starknet_mempool): add TransactionReference new from InternalRpcTransaction #3502
• feat(starknet_api): add getters for InternalRpcTransaction #3501
• feat(starknet_mempool_p2p): add class manager to propogator #3500
• refactor(starknet_gateway): remove unused gateway compiler #3499
• feat(starknet_gateway): get executable tx from class manager #3498
• feat(starknet_gateway): add class manager client #3497 : 3 other dependent PRs (#3578 , #3581 , #3608 )
• fix(starknet_gateway): remove compiled_class_hash_mismatch test #3609
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Artifacts upload workflows:

• Started at 2025-01-20T14:19:41Z
• Started at 2025-01-21T05:35:11Z
• Started at 2025-01-21T12:52:50Z
• Started at 2025-01-21T15:34:01Z
• Started at 2025-01-22T10:45:51Z

[ShahakShama]

Reviewed 6 of 8 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @noamsp-starkware)

---

crates/starknet_batcher/src/batcher.rs line 640 at r2 (raw file):

    let transaction_converter = TransactionConverter::new(
        class_manager_client,
        config.block_builder_config.chain_info.chain_id.clone(),

@ArniStarkware @ayeletstarkware is it more correct to get the chain id from here or from storage config?

---

crates/starknet_batcher/src/transaction_provider_test.rs line 93 at r2 (raw file):

        tx_sender,
        tx_receiver,
        // TODO(noamsp): use MockTransactionConverter

Same

---

crates/starknet_batcher/src/batcher_test.rs line 103 at r2 (raw file):

            mempool_client: MockMempoolClient::new(),
            block_builder_factory: MockBlockBuilderFactoryTrait::new(),
            // TODO(noamsp): use MockTransactionConverter

In this case I think it's more correct using MockClassManagerClient. Especially because you're going to use it in the state reader as well

---

crates/starknet_api/src/test_utils/invoke.rs line 159 at r2 (raw file):

}

pub fn internal_invoke_tx(invoke_args: InvokeTxArgs) -> InternalRpcTransaction {

I'd like the person who wrote the rest of these to review this as well
From a quick git blame it looks like it's either @ArniStarkware or @ayeletstarkware

[ArniStarkware]

Reviewed 1 of 8 files at r1.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @ayeletstarkware and @noamsp-starkware)

---

crates/starknet_api/src/test_utils/invoke.rs line 159 at r2 (raw file):

Previously, ShahakShama wrote…

I'd like the person who wrote the rest of these to review this as well
From a quick git blame it looks like it's either @ArniStarkware or @ayeletstarkware

___ *[`crates/starknet_batcher/src/batcher.rs` line 640 at r2](https://reviewable.io/reviews/starkware-libs/sequencer/3509#-OH8AUrw62tRxPkYCukA:-OH8EB2s4JiTuCKwR7ai:bpkaehd) ([raw file](https://github.com/starkware-libs/sequencer/blob/0811a41b34eb77af741ec2e47a1c8037f149f3de/crates/starknet_batcher/src/batcher.rs#L640)):*

Previously, ShahakShama wrote…

@ArniStarkware @ayeletstarkware is it more correct to get the chain id from here or from storage config?

Theoretically, Both are fine. Both should be the same value (if not, we have a problem).

I see that in storage config the extraction of the value is more direct.

[noamsp-starkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ayeletstarkware)

---

crates/starknet_batcher/src/batcher.rs line 640 at r2 (raw file):

Previously, ArniStarkware (Arnon Hod) wrote…

Theoretically, Both are fine. Both should be the same value (if not, we have a problem).

I see that in storage config the extraction of the value is more direct.

@ArniStarkware Changed as you suggested

[ShahakShama]

Reviewed 7 of 7 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ayeletstarkware)