refactor: use InternalRpcTransaction in gateway and mempool#3510
Merged
Conversation
|
This change is |
This was referenced Jan 20, 2025
Merged
Contributor
Author
noamsp-starkware
force-pushed
the
noam.s/feat_starknet_batcher_use_transaction_converter_to_infer_executable_from_mempool_internal_tx
branch
from
59b9bb4 to
b187730
Compare
noamsp-starkware
force-pushed
the
noam.s/refactor_use_InternalRpcTransaction_in_gateway_and_mempool
branch
from
916d8c4 to
d295d5f
Compare
noamsp-starkware
force-pushed
the
noam.s/feat_starknet_batcher_use_transaction_converter_to_infer_executable_from_mempool_internal_tx
branch
from
b187730 to
0c801e7
Compare
noamsp-starkware
force-pushed
the
noam.s/refactor_use_InternalRpcTransaction_in_gateway_and_mempool
branch
from
d295d5f to
26e12c3
Compare
noamsp-starkware
force-pushed
the
noam.s/feat_starknet_batcher_use_transaction_converter_to_infer_executable_from_mempool_internal_tx
branch
from
0c801e7 to
0811a41
Compare
noamsp-starkware
force-pushed
the
noam.s/refactor_use_InternalRpcTransaction_in_gateway_and_mempool
branch
from
26e12c3 to
54882ac
Compare
ShahakShama
approved these changes
Jan 21, 2025
Collaborator
ShahakShama
left a comment
ShahakShama
left a comment
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware)
noamsp-starkware
force-pushed
the
noam.s/feat_starknet_batcher_use_transaction_converter_to_infer_executable_from_mempool_internal_tx
branch
from
0811a41 to
066ebde
Compare
noamsp-starkware
force-pushed
the
noam.s/refactor_use_InternalRpcTransaction_in_gateway_and_mempool
branch
from
54882ac to
969e489
Compare
This was referenced Jan 21, 2025
noamsp-starkware
merged commit 8d78f2c
into
noam.s/feat_starknet_batcher_use_transaction_converter_to_infer_executable_from_mempool_internal_tx
9 of 13 checks passed
noamsp-starkware
deleted the
noam.s/refactor_use_InternalRpcTransaction_in_gateway_and_mempool
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.