Skip to content

fix(starknet_gateway): remove compiled_class_hash_mismatch test#3581

Closed
noamsp-starkware wants to merge 1 commit intonoam.s/feat_starknet_gateway_add_class_manager_clientfrom
noam.s/fix_starknet_gateway_remove_compiled_class_hash_mismatch_test
Closed

fix(starknet_gateway): remove compiled_class_hash_mismatch test#3581
noamsp-starkware wants to merge 1 commit intonoam.s/feat_starknet_gateway_add_class_manager_clientfrom
noam.s/fix_starknet_gateway_remove_compiled_class_hash_mismatch_test

Conversation

@noamsp-starkware
Copy link
Contributor

@noamsp-starkware noamsp-starkware commented Jan 21, 2025

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

noamsp-starkware commented Jan 21, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@noamsp-starkware noamsp-starkware force-pushed the noam.s/feat_starknet_gateway_state_reader_get_compiled_classes_from_class_manager branch from 4f7fe17 to 4921fbd Compare January 21, 2025 18:44
@noamsp-starkware noamsp-starkware force-pushed the noam.s/fix_starknet_gateway_remove_compiled_class_hash_mismatch_test branch from 0fe0bac to d245d69 Compare January 21, 2025 18:45
@noamsp-starkware noamsp-starkware force-pushed the noam.s/feat_starknet_gateway_state_reader_get_compiled_classes_from_class_manager branch from 4921fbd to 1989395 Compare January 22, 2025 11:05
@noamsp-starkware noamsp-starkware force-pushed the noam.s/fix_starknet_gateway_remove_compiled_class_hash_mismatch_test branch from d245d69 to b5bc24f Compare January 22, 2025 11:05
@noamsp-starkware noamsp-starkware force-pushed the noam.s/feat_starknet_gateway_state_reader_get_compiled_classes_from_class_manager branch 2 times, most recently from 6f01955 to 4870e47 Compare January 22, 2025 12:20
@noamsp-starkware noamsp-starkware deleted the noam.s/fix_starknet_gateway_remove_compiled_class_hash_mismatch_test branch January 22, 2025 12:22
@noamsp-starkware noamsp-starkware restored the noam.s/fix_starknet_gateway_remove_compiled_class_hash_mismatch_test branch January 22, 2025 15:07
@noamsp-starkware noamsp-starkware force-pushed the noam.s/fix_starknet_gateway_remove_compiled_class_hash_mismatch_test branch from b5bc24f to 3d1bacb Compare January 22, 2025 15:42
@noamsp-starkware noamsp-starkware changed the base branch from noam.s/feat_starknet_gateway_state_reader_get_compiled_classes_from_class_manager to noam.s/feat_starknet_gateway_add_class_manager_client January 22, 2025 15:43
This test was removed until convert_rpc_tx_to_internal_rpc_tx is
implemented
@noamsp-starkware noamsp-starkware force-pushed the noam.s/fix_starknet_gateway_remove_compiled_class_hash_mismatch_test branch from 3d1bacb to 4828d7f Compare January 22, 2025 15:47
@noamsp-starkware noamsp-starkware marked this pull request as ready for review January 22, 2025 15:49
@noamsp-starkware noamsp-starkware deleted the noam.s/fix_starknet_gateway_remove_compiled_class_hash_mismatch_test branch January 22, 2025 15:59
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants