Skip to content

fix(starknet_gateway): remove compiled_class_hash_mismatch test#3609

Merged
ShahakShama merged 1 commit intomainfrom
noam.s/remove_compiled_class_hash_mismatch
Jan 23, 2025
Merged

fix(starknet_gateway): remove compiled_class_hash_mismatch test#3609
ShahakShama merged 1 commit intomainfrom
noam.s/remove_compiled_class_hash_mismatch

Conversation

@noamsp-starkware
Copy link
Contributor

@noamsp-starkware noamsp-starkware commented Jan 22, 2025

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

noamsp-starkware commented Jan 22, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@noamsp-starkware noamsp-starkware force-pushed the noam.s/remove_compiled_class_hash_mismatch branch from 4828d7f to 6cda1dc Compare January 22, 2025 16:00
@noamsp-starkware noamsp-starkware marked this pull request as ready for review January 22, 2025 16:02
Copy link
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @noamsp-starkware)


a discussion (no related file):
@alonh5 should also approve this


crates/starknet_gateway/src/gateway_test.rs line 174 at r1 (raw file):

// metadata.

#[rstest]

Instead of deleting this. Ignore the test with #[ignore]

Copy link
Contributor

@alonh5 alonh5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @noamsp-starkware)

@noamsp-starkware noamsp-starkware force-pushed the noam.s/remove_compiled_class_hash_mismatch branch from 6cda1dc to 534dbda Compare January 23, 2025 09:46
@noamsp-starkware noamsp-starkware changed the base branch from noam.s/feat_starknet_gateway_add_class_manager_client to main January 23, 2025 09:46
Copy link
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @noamsp-starkware)

temporary ignore of test until class manager is implemented.
@noamsp-starkware noamsp-starkware force-pushed the noam.s/remove_compiled_class_hash_mismatch branch from 534dbda to bf1d245 Compare January 23, 2025 09:49
Copy link
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @noamsp-starkware)

Copy link
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noamsp-starkware)

@ShahakShama ShahakShama added this pull request to the merge queue Jan 23, 2025
Merged via the queue into main with commit 6e231f6 Jan 23, 2025
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2025
@noamsp-starkware noamsp-starkware deleted the noam.s/remove_compiled_class_hash_mismatch branch January 27, 2025 11:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants