fix(starknet_gateway): handle convert internal to executable err#3608
Closed
noamsp-starkware wants to merge 12 commits intonoam.s/feat_starknet_gateway_add_class_manager_clientfrom
Conversation
|
This change is |
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
noamsp-starkware
force-pushed
the
noam.s/fix_starknet_gateway_remove_compiled_class_hash_mismatch_test
branch
from
3d1bacb to
4828d7f
Compare
noamsp-starkware
force-pushed
the
noam.s/fix_starknet_gateway_handle_convert_internal_to_executable_err
branch
from
a23ac93 to
e05eb6d
Compare
noamsp-starkware
changed the base branch from
noam.s/fix_starknet_gateway_remove_compiled_class_hash_mismatch_test
to
noam.s/remove_compiled_class_hash_mismatch
noamsp-starkware
force-pushed
the
noam.s/remove_compiled_class_hash_mismatch
branch
from
4828d7f to
6cda1dc
Compare
noamsp-starkware
force-pushed
the
noam.s/fix_starknet_gateway_handle_convert_internal_to_executable_err
branch
from
e05eb6d to
eca01d5
Compare
ShahakShama
approved these changes
Jan 23, 2025
Collaborator
ShahakShama
left a comment
ShahakShama
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware)
noamsp-starkware
force-pushed
the
noam.s/remove_compiled_class_hash_mismatch
branch
from
6cda1dc to
534dbda
Compare
This was referenced Jan 23, 2025
feat(starknet_batcher): use transaction converter to infer executable from mempool internal tx
#3509
Merged
temporary ignore of test until class manager is implemented.
… from mempool internal tx
noamsp-starkware
force-pushed
the
noam.s/remove_compiled_class_hash_mismatch
branch
from
534dbda to
bf1d245
Compare
noamsp-starkware
force-pushed
the
noam.s/fix_starknet_gateway_handle_convert_internal_to_executable_err
branch
from
eca01d5 to
24bcb08
Compare
noamsp-starkware
changed the base branch from
noam.s/remove_compiled_class_hash_mismatch
to
noam.s/feat_starknet_gateway_add_class_manager_client
|
Artifacts upload workflows: |
ShahakShama
force-pushed
the
noam.s/feat_starknet_gateway_add_class_manager_client
branch
2 times, most recently
from
8f3af62 to
8c34d6b
Compare
noamsp-starkware
deleted the
noam.s/fix_starknet_gateway_handle_convert_internal_to_executable_err
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.