feat(starknet_gateway): get executable tx from class manager

[noamsp-starkware]

No description provided.

[noamsp-starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• feat(starknet_mempool): handle declare tx properly #3512
• refactor: align gateway and mempool tests with InternalRpcTx change #3511
• refactor: use InternalRpcTransaction in gateway and mempool #3510
• feat(starknet_batcher): use transaction converter to infer executable from mempool internal tx #3509
• feat(starknet_mempool): add TransactionReference new from InternalRpcTransaction #3502
• feat(starknet_api): add getters for InternalRpcTransaction #3501
• feat(starknet_mempool_p2p): add class manager to propogator #3500
• refactor(starknet_gateway): remove unused gateway compiler #3499
• feat(starknet_gateway): get executable tx from class manager #3498 👈 (View in Graphite)
• feat(starknet_gateway): add class manager client #3497 : 3 other dependent PRs (#3578 , #3581 , #3608 )
• fix(starknet_gateway): remove compiled_class_hash_mismatch test #3609
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[reviewable-StarkWare]

This change is 

[ShahakShama]

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @noamsp-starkware)

---

crates/starknet_gateway/src/utils.rs line 19 at r1 (raw file):

/// executable contract class.
#[allow(dead_code)]
pub fn compile_contract_and_build_executable_tx(

Delete this function

---

crates/starknet_gateway/src/gateway.rs line 103 at r1 (raw file):

    stateful_tx_validator: Arc<StatefulTransactionValidator>,
    state_reader_factory: Arc<dyn StateReaderFactory>,
    // TODO(noamsp): remove gatewayCompiler

Change to "remove GatewayCompiler from here and erase it.

---

crates/starknet_gateway/src/gateway.rs line 132 at r1 (raw file):

        self.stateless_tx_validator.validate(&self.tx)?;

        // TODO(noamsp): Add error handling.

Do this now. I think you should do what they did in compile_contract_and_build_executable_tx:

sequencer/crates/starknet_gateway/src/utils.rs

Line 41 in 5c0226f

GatewaySpecError::UnexpectedError {

[noamsp-starkware]

Reviewable status: 2 of 5 files reviewed, 3 unresolved discussions (waiting on @ShahakShama)

---

crates/starknet_gateway/src/gateway.rs line 103 at r1 (raw file):

Previously, ShahakShama wrote…

Change to "remove GatewayCompiler from here and erase it.

Done.

---

crates/starknet_gateway/src/gateway.rs line 132 at r1 (raw file):

Previously, ShahakShama wrote…

Do this now. I think you should do what they did in compile_contract_and_build_executable_tx:

sequencer/crates/starknet_gateway/src/utils.rs

Line 41 in 5c0226f

GatewaySpecError::UnexpectedError {

Done.

---

crates/starknet_gateway/src/utils.rs line 19 at r1 (raw file):

Previously, ShahakShama wrote…

Delete this function

Its deleted in the following PR.

[ShahakShama]

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware)

[ShahakShama]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware)