Skip to content

refactor: align gateway and mempool tests with InternalRpcTx change#3511

Merged
noamsp-starkware merged 2 commits intonoam.s/refactor_use_InternalRpcTransaction_in_gateway_and_mempoolfrom
noam.s/refactor_align_gateway_and_mempool_tests_with_InternalRpcTx_change
Jan 22, 2025
Merged

refactor: align gateway and mempool tests with InternalRpcTx change#3511
noamsp-starkware merged 2 commits intonoam.s/refactor_use_InternalRpcTransaction_in_gateway_and_mempoolfrom
noam.s/refactor_align_gateway_and_mempool_tests_with_InternalRpcTx_change

Conversation

@noamsp-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@noamsp-starkware noamsp-starkware marked this pull request as ready for review January 20, 2025 12:27
@noamsp-starkware noamsp-starkware force-pushed the noam.s/refactor_use_InternalRpcTransaction_in_gateway_and_mempool branch from 916d8c4 to d295d5f Compare January 20, 2025 14:19
@noamsp-starkware noamsp-starkware force-pushed the noam.s/refactor_align_gateway_and_mempool_tests_with_InternalRpcTx_change branch from 773890b to 9282c2c Compare January 20, 2025 14:19
@noamsp-starkware noamsp-starkware force-pushed the noam.s/refactor_use_InternalRpcTransaction_in_gateway_and_mempool branch from d295d5f to 26e12c3 Compare January 21, 2025 05:35
@noamsp-starkware noamsp-starkware force-pushed the noam.s/refactor_align_gateway_and_mempool_tests_with_InternalRpcTx_change branch from 9282c2c to 47569c1 Compare January 21, 2025 05:35
@noamsp-starkware noamsp-starkware force-pushed the noam.s/refactor_use_InternalRpcTransaction_in_gateway_and_mempool branch from 26e12c3 to 54882ac Compare January 21, 2025 12:52
@noamsp-starkware noamsp-starkware force-pushed the noam.s/refactor_align_gateway_and_mempool_tests_with_InternalRpcTx_change branch from 47569c1 to b4f5f15 Compare January 21, 2025 12:53
Copy link
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noamsp-starkware)


crates/starknet_mempool_p2p/src/propagator/test.rs line 35 at r1 (raw file):

        subscriber_channels;
    let BroadcastNetworkMock { mut messages_to_broadcast_receiver, .. } = mock_network;
    let rpc_transaction = RpcTransaction::get_test_instance(&mut get_rng());

Create an InternalRpcTransaction and convert it to RpcTransaction instead. You can leave a TODO for now if you prefer

Copy link
Contributor Author

@noamsp-starkware noamsp-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware)


crates/starknet_mempool_p2p/src/propagator/test.rs line 35 at r1 (raw file):

Previously, ShahakShama wrote…

Create an InternalRpcTransaction and convert it to RpcTransaction instead. You can leave a TODO for now if you prefer

Done.

@noamsp-starkware noamsp-starkware force-pushed the noam.s/refactor_use_InternalRpcTransaction_in_gateway_and_mempool branch from 54882ac to 969e489 Compare January 21, 2025 15:34
@noamsp-starkware noamsp-starkware force-pushed the noam.s/refactor_align_gateway_and_mempool_tests_with_InternalRpcTx_change branch from b4f5f15 to a759c0f Compare January 21, 2025 15:34
Copy link
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware)

@noamsp-starkware noamsp-starkware merged commit 978be21 into noam.s/refactor_use_InternalRpcTransaction_in_gateway_and_mempool Jan 22, 2025
9 of 13 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2025
@noamsp-starkware noamsp-starkware deleted the noam.s/refactor_align_gateway_and_mempool_tests_with_InternalRpcTx_change branch January 27, 2025 11:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants