refactor: align gateway and mempool tests with InternalRpcTx change#3511
Conversation
916d8c4 to
d295d5f
Compare
773890b to
9282c2c
Compare
d295d5f to
26e12c3
Compare
9282c2c to
47569c1
Compare
26e12c3 to
54882ac
Compare
47569c1 to
b4f5f15
Compare
ShahakShama
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @noamsp-starkware)
crates/starknet_mempool_p2p/src/propagator/test.rs line 35 at r1 (raw file):
subscriber_channels; let BroadcastNetworkMock { mut messages_to_broadcast_receiver, .. } = mock_network; let rpc_transaction = RpcTransaction::get_test_instance(&mut get_rng());
Create an InternalRpcTransaction and convert it to RpcTransaction instead. You can leave a TODO for now if you prefer
noamsp-starkware
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware)
crates/starknet_mempool_p2p/src/propagator/test.rs line 35 at r1 (raw file):
Previously, ShahakShama wrote…
Create an InternalRpcTransaction and convert it to RpcTransaction instead. You can leave a TODO for now if you prefer
Done.
54882ac to
969e489
Compare
b4f5f15 to
a759c0f
Compare
ShahakShama
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware)
978be21
into
noam.s/refactor_use_InternalRpcTransaction_in_gateway_and_mempool

No description provided.