apollo_gateway: expose l2_gas_price towards reject on insufficient gas price

[ArniStarkware]

No description provided.

[reviewable-StarkWare]

This change is 

[ArniStarkware]

• apollo_gateway: add config for min_gas_price_precentage for threshold #7720
• apollo_gateway: reject tx with low l2 gas price #7717
• apollo_gateway: expose l2_gas_price towards reject on insufficient gas price #7712 👈 (View in Graphite)
• main-v0.14.0

This stack of pull requests is managed by Graphite. Learn more about stacking.

[ayeletstarkware]

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @alonh5)

---

crates/apollo_gateway/src/stateful_transaction_validator.rs line 113 at r1 (raw file):

        // StatefulTransactionValidator and update it only once a new block is created.
        let latest_block_info = get_latest_block_info(state_reader_factory)?;
        let l2_gas_price = latest_block_info.gas_prices.strk_gas_prices.l2_gas_price;

Consider calling these lines outside this function (in process_tx or in a helper function)? because this function instantiates a blockifier stateful validator and the l2 gas price is not a part of it (?)
OR, change the func name

Code quote:

        let latest_block_info = get_latest_block_info(state_reader_factory)?;
        let l2_gas_price = latest_block_info.gas_prices.strk_gas_prices.l2_gas_price;

---

crates/apollo_gateway/src/stateful_transaction_validator.rs line 130 at r1 (raw file):

        );

        let blockifier_statefult_validator =

Suggestion:

blockifier_stateful_validator

[github-actions]

Artifacts upload workflows:

• Started at 2025-07-01T15:56:04Z
• Started at 2025-07-02T17:38:21Z
• Started at 2025-07-03T07:13:36Z
• Started at 2025-07-03T07:15:09Z

[ArniStarkware]

Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @alonh5)

---

crates/apollo_gateway/src/stateful_transaction_validator.rs line 113 at r1 (raw file):

Previously, ayeletstarkware (Ayelet Zilber) wrote…

Consider calling these lines outside this function (in process_tx or in a helper function)? because this function instantiates a blockifier stateful validator and the l2 gas price is not a part of it (?)
OR, change the func name

Done.

---

crates/apollo_gateway/src/stateful_transaction_validator.rs line 130 at r1 (raw file):

        );

        let blockifier_statefult_validator =

stale

[ayeletstarkware]

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alonh5)

[alonh5]

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

[alonh5]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)

---

a discussion (no related file):
Please add @ShahakShama and @dan-starkware as reviewers to this stack

[ShahakShama]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ArniStarkware and @dan-starkware)

---

crates/apollo_gateway/src/gateway.rs line 209 at r2 (raw file):

        // threshold.
        let _l2_gas_price =
            validator.block_context().block_info().gas_prices.strk_gas_prices.l2_gas_price;

You have the next_l2_gas_price inside the block header. Why not use it?

[ArniStarkware]

Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on @alonh5, @ayeletstarkware, @dan-starkware, and @ShahakShama)

---

crates/apollo_gateway/src/gateway.rs line 209 at r2 (raw file):

Previously, ShahakShama wrote…

You have the next_l2_gas_price inside the block header. Why not use it?

1. I see that the gateway's state reader will always produce a SyncStateReader. The type of StateReaderFactory allows us to produce an RpcStateReader. It might no longer be supported, but a refactor is required for us to count on it at this point in the code. RpcStateReader does not have the field next_l2_gas_price IIUC.

2. I don't want to make other blocking calls to the state to the state reader. There is a call to get_block_info. This call is blocking on an async action:
   

   sequencer/crates/apollo_gateway/src/sync_state_reader.rs

   Line 41 in 3add2fd

   let block = block_on(self.state_sync_client.get_block(self.block_number))

   
   Again, we can refactor the SyncStateReader to expose this interface, and hopefully do fewer blocking calls, but this requires a refactor.

3. I didn't want to break the abstraction (a lot), so I used the existing executor.

Possible solution - create a wrapper to BlockInfo that also holds (an optional?) next_l2_gas_price.

Anyway - sounds like work for another day. Correct? Added a todo.

[ArniStarkware]

Reviewable status: 2 of 3 files reviewed, 2 unresolved discussions (waiting on @alonh5, @ayeletstarkware, @dan-starkware, and @ShahakShama)

---

a discussion (no related file):

Previously, alonh5 (Alon Haramati) wrote…

Please add @ShahakShama and @dan-starkware as reviewers to this stack

Now merging into main-v0.14.0. This comment is no longer relevant.

[ShahakShama]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alonh5, @ayeletstarkware, and @dan-starkware)

[ArniStarkware]

Folded the following PRs into this one:
#7717
#7720

[github-actions]

Benchmark movements: No major performance changes detected.

[ayeletstarkware]

Reviewed 2 of 4 files at r4, 4 of 4 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alonh5 and @dan-starkware)

[ArniStarkware]

Dismissed @alonh5 from a discussion.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @alonh5 and @dan-starkware)

No longer relevant.