apollo_gateway: add config for min_gas_price_precentage for threshold

[ArniStarkware]

No description provided.

[reviewable-StarkWare]

This change is 

[ArniStarkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• apollo_gateway: add config for min_gas_price_precentage for threshold #7720 👈 (View in Graphite)
• apollo_gateway: reject tx with low l2 gas price #7717
• apollo_gateway: expose l2_gas_price towards reject on insufficient gas price #7712
• main-v0.14.0

This stack of pull requests is managed by Graphite. Learn more about stacking.

[ayeletstarkware]

Reviewed 1 of 4 files at r1, all commit messages.
Reviewable status: 1 of 4 files reviewed, 1 unresolved discussion (waiting on @alonh5)

---

crates/apollo_gateway/src/config.rs line 176 at r2 (raw file):

    pub versioned_constants_overrides: VersionedConstantsOverrides,
    // Minimum gas price as percentage of threshold to accept transactions.
    pub min_gas_price_precentage: u8, // E.g., 80 to require 80% of threshold.

Consider using 0.8 instead of 80 to remove the need for percentage-to-ratio conversion.

[ArniStarkware]

Reviewable status: 1 of 4 files reviewed, 1 unresolved discussion (waiting on @alonh5 and @ayeletstarkware)

---

crates/apollo_gateway/src/config.rs line 176 at r2 (raw file):

Previously, ayeletstarkware (Ayelet Zilber) wrote…

Consider using 0.8 instead of 80 to remove the need for percentage-to-ratio conversion.

But then the type is a float.
We hate float.

[alonh5]

PR looks good. Did we calculate what the percentage we want is? We should probably think of how much percentage the price could move in ~10 blocks, and have that be the threshold.

Reviewed 2 of 4 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ayeletstarkware)

[ayeletstarkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

[ArniStarkware]

Apparently, the most the gas price changes between blocks is by a factor of 1/48. Turns out this implies 0.8 is the perfect factor.

If C=1-1/48, then C^11 < 0.8 < C^10. Passing it by @leo-starkware as well.

[ShahakShama]

Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ArniStarkware)

---

crates/apollo_gateway/src/config.rs line 176 at r3 (raw file):

    pub versioned_constants_overrides: VersionedConstantsOverrides,
    // Minimum gas price as percentage of threshold to accept transactions.
    pub min_gas_price_percentage: u8, // E.g., 80 to require 80% of threshold.

Why not float?

[ArniStarkware]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArniStarkware)

---

crates/apollo_gateway/src/config.rs line 176 at r3 (raw file):

Previously, ShahakShama wrote…

Why not float?

https://reviewable.io/reviews/starkware-libs/sequencer/7720#-OU9o9IODkWi6zwWu9-K

Lior hates floats.