Skip to content

Conversation

@dorimedini-starkware
Copy link
Collaborator

No description provided.

avivg-starkware and others added 30 commits June 25, 2025 17:08
@dorimedini-starkware dorimedini-starkware self-assigned this Jul 6, 2025
@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 225 of 225 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@github-actions
Copy link

github-actions bot commented Jul 6, 2025

@github-actions
Copy link

github-actions bot commented Jul 6, 2025

Benchmark movements: No major performance changes detected.

@dorimedini-starkware dorimedini-starkware force-pushed the dori/merge-main-v0.14.0-into-main-1751811445 branch from 3939075 to 7ab8c08 Compare July 6, 2025 15:19
Copy link
Collaborator

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 14 of 25 files at r2.
Reviewable status: 215 of 226 files reviewed, all discussions resolved (waiting on @meship-starkware)

Copy link
Collaborator

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 225 files at r1, 4 of 25 files at r2.
Reviewable status: 219 of 226 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)


crates/blockifier/src/bouncer.rs line 534 at r2 (raw file):

                .collect::<HashSet<_>>(),
            "Sierra and proving gas data should have the same class hashes."
        );

Can you remove this? It seems like we accidentally did it twice. You can also add a todo for me to do it later

Code quote:

        assert_eq!(
            tx_weights
                .casm_hash_computation_data_sierra_gas
                .class_hash_to_casm_hash_computation_gas
                .keys()
                .collect::<HashSet<_>>(),
            tx_weights
                .casm_hash_computation_data_proving_gas
                .class_hash_to_casm_hash_computation_gas
                .keys()
                .collect::<HashSet<_>>(),
            "Sierra and proving gas data should have the same class hashes."
        );

Copy link
Collaborator

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 16 of 25 files at r2, all commit messages.
Reviewable status: 221 of 226 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)

Copy link
Collaborator

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 191 of 225 files at r1, 4 of 25 files at r2.
Reviewable status: 225 of 226 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)

Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 225 of 226 files reviewed, 1 unresolved discussion (waiting on @meship-starkware)


crates/blockifier/src/bouncer.rs line 534 at r2 (raw file):

Previously, meship-starkware (Meshi Peled) wrote…

Can you remove this? It seems like we accidentally did it twice. You can also add a todo for me to do it later

where is the second appearance?

Signed-off-by: Dori Medini <[email protected]>
@dorimedini-starkware dorimedini-starkware force-pushed the dori/merge-main-v0.14.0-into-main-1751811445 branch from 7ab8c08 to 5233349 Compare July 7, 2025 07:09
Copy link
Collaborator

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 25 files at r2, 1 of 1 files at r3.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @dorimedini-starkware)

Copy link
Collaborator

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @dorimedini-starkware)

Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue Jul 7, 2025
Merged via the queue into main with commit 84d3a33 Jul 7, 2025
32 of 34 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.