-
Notifications
You must be signed in to change notification settings - Fork 65
Merge main-v0.14.0 into main #7802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge main-v0.14.0 into main #7802
Conversation
…osalResult instead of Option (#7508)
… fee escalation (#7627)
…ng replacements (#7581)
Signed-off-by: Dori Medini <[email protected]>
…me appropriately (#7649)
…arknet Foundry (#6485) Signed-off-by: Dori Medini <[email protected]>
Signed-off-by: Dori Medini <[email protected]>
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 225 of 225 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
2612d6c to
3939075
Compare
|
Benchmark movements: No major performance changes detected. |
3939075 to
7ab8c08
Compare
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 14 of 25 files at r2.
Reviewable status: 215 of 226 files reviewed, all discussions resolved (waiting on @meship-starkware)
meship-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 10 of 225 files at r1, 4 of 25 files at r2.
Reviewable status: 219 of 226 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)
crates/blockifier/src/bouncer.rs line 534 at r2 (raw file):
.collect::<HashSet<_>>(), "Sierra and proving gas data should have the same class hashes." );
Can you remove this? It seems like we accidentally did it twice. You can also add a todo for me to do it later
Code quote:
assert_eq!(
tx_weights
.casm_hash_computation_data_sierra_gas
.class_hash_to_casm_hash_computation_gas
.keys()
.collect::<HashSet<_>>(),
tx_weights
.casm_hash_computation_data_proving_gas
.class_hash_to_casm_hash_computation_gas
.keys()
.collect::<HashSet<_>>(),
"Sierra and proving gas data should have the same class hashes."
);
meship-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 16 of 25 files at r2, all commit messages.
Reviewable status: 221 of 226 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)
meship-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 191 of 225 files at r1, 4 of 25 files at r2.
Reviewable status: 225 of 226 files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 225 of 226 files reviewed, 1 unresolved discussion (waiting on @meship-starkware)
crates/blockifier/src/bouncer.rs line 534 at r2 (raw file):
Previously, meship-starkware (Meshi Peled) wrote…
Can you remove this? It seems like we accidentally did it twice. You can also add a todo for me to do it later
where is the second appearance?
Signed-off-by: Dori Medini <[email protected]>
7ab8c08 to
5233349
Compare
meship-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 25 files at r2, 1 of 1 files at r3.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @dorimedini-starkware)
meship-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @dorimedini-starkware)
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
No description provided.