Skip to content

apollo_network: broadcast_network_stress_test_node updated message#9336

Merged
sirandreww-starkware merged 1 commit intomainfrom
25-sep-17-broadcast-network-stress-test-1
Sep 29, 2025
Merged

apollo_network: broadcast_network_stress_test_node updated message#9336
sirandreww-starkware merged 1 commit intomainfrom
25-sep-17-broadcast-network-stress-test-1

Conversation

@sirandreww-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@sirandreww-starkware sirandreww-starkware self-assigned this Sep 17, 2025
Copy link
Contributor Author

sirandreww-starkware commented Sep 17, 2025

Copy link
Collaborator

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ShahakShama reviewed 2 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sirandreww-starkware)


crates/apollo_network/src/bin/broadcast_network_stress_test_node/converters.rs line 15 at r2 (raw file):

#[derive(Debug, Clone, Copy)]
pub struct StressTestMessageMetaData {

Metadata is one word, no need to capitalize the D

@sirandreww-starkware sirandreww-starkware force-pushed the 25-sep-17-broadcast-network-stress-test-1 branch from 5d2213f to 018e1b1 Compare September 29, 2025 13:17
Copy link
Contributor Author

@sirandreww-starkware sirandreww-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sirandreww-starkware reviewed 1 of 2 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @sirandreww-starkware)

@sirandreww-starkware sirandreww-starkware force-pushed the 25-sep-17-broadcast-network-stress-test-1 branch from 018e1b1 to 00e689e Compare September 29, 2025 13:31
Copy link
Contributor Author

@sirandreww-starkware sirandreww-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sirandreww-starkware reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @sirandreww-starkware)

@sirandreww-starkware sirandreww-starkware added this pull request to the merge queue Sep 29, 2025
Merged via the queue into main with commit c9be0fa Sep 29, 2025
20 of 22 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants