apollo_network: broadcast network stress test draft #8303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Contributor
Author
![semgrep-code-starkware-libs[bot]](https://avatars.githubusercontent.com/u/59333826?s=60&v=4){kind=small}
| try: | ||
| result = subprocess.run( | ||
| cmd, | ||
| shell=True, |
There was a problem hiding this comment.
Found 'subprocess' function 'run' with 'shell=True'. This is dangerous because this call will spawn the command using a shell process. Doing so propagates current shell settings and variables, which makes it much easier for a malicious actor to execute commands. Use 'shell=False' instead.
🍰 Removed in commit d7d84ce 🍰
|
Benchmark movements: full_committer_flow performance regressed! full_committer_flow time: [16.824 ms 17.056 ms 17.298 ms] change: [+3.6401% +5.5651% +7.4524%] (p = 0.00 < 0.05) Performance has regressed. Found 3 outliers among 100 measurements (3.00%) 3 (3.00%) high mild |
sirandreww-starkware
force-pushed
the
graphite-base/8303
branch
from
d04380c to
61e6485
Compare
sirandreww-starkware
force-pushed
the
07-29-apollo-network-broadcast-network-stress-test-draft
branch
from
b24e12f to
30f4a37
Compare
sirandreww-starkware
changed the base branch from
graphite-base/8303
to
07-29-waker-option-instead-of-vec-fix
sirandreww-starkware
changed the base branch from
07-29-waker-option-instead-of-vec-fix
to
graphite-base/8303
sirandreww-starkware
force-pushed
the
07-29-apollo-network-broadcast-network-stress-test-draft
branch
from
30f4a37 to
a604cea
Compare
sirandreww-starkware
force-pushed
the
graphite-base/8303
branch
from
61e6485 to
a52944b
Compare
sirandreww-starkware
changed the base branch from
graphite-base/8303
to
07-31-apollo_network_decreased_hearbeat_length_and_history_and_gossip
This was referenced Aug 6, 2025
sirandreww-starkware
changed the base branch from
07-31-apollo_network_decreased_hearbeat_length_and_history_and_gossip
to
graphite-base/8303
sirandreww-starkware
force-pushed
the
07-29-apollo-network-broadcast-network-stress-test-draft
branch
from
a604cea to
f9b196a
Compare
sirandreww-starkware
force-pushed
the
graphite-base/8303
branch
from
a52944b to
8f65443
Compare
sirandreww-starkware
changed the base branch from
graphite-base/8303
to
07-30-apollo_network_turned_off_flood_publish_in_gossipsub
This was referenced Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.