apollo_network_benchmark: add SQMR protocol constant#11549
Open
sirandreww-starkware wants to merge 1 commit into01-07-apollo_network_benchmark_added_ping_latency_metricsfrom
Conversation
Contributor
Author
This was referenced Jan 8, 2026
|
There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. |
|
|
||
| pub type TopicType = Vec<u8>; | ||
|
|
||
| pub const SQMR_PROTOCOL_NAME: &str = "/stress-test/1.0.0"; |
There was a problem hiding this comment.
Unused SQMR protocol constant added
Low Severity
SQMR_PROTOCOL_NAME is introduced in protocol.rs but is never referenced anywhere in the codebase. This leaves dead code in the stress test protocol path and can mislead readers into assuming SQMR is wired when the current logic still only uses NetworkProtocol::Gossipsub.
4083c5d to
9b3fdfa
Compare
9b3fdfa to
766686d
Compare
5e4a06d to
4cf8b68
Compare
This was referenced Feb 19, 2026
4cf8b68 to
c5160fd
Compare
766686d to
3abc921
Compare
c5160fd to
3bad93e
Compare
3abc921 to
13f2310
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Note
Low Risk
Low risk: adds a single string constant with no behavioral changes; impact is limited to any future code that starts referencing this identifier.
Overview
Defines
SQMR_PROTOCOL_NAME("/stress-test/1.0.0") inbroadcast_network_stress_test_node/protocol.rsfor use as a stable protocol identifier in the network stress test node.Written by Cursor Bugbot for commit 13f2310. This will update automatically on new commits. Configure here.