Skip to content

apollo_network_benchmark: add SQMR protocol constant#11549

Open
sirandreww-starkware wants to merge 1 commit into01-07-apollo_network_benchmark_added_ping_latency_metricsfrom
01-08-apollo_network_benchmark_add_sqmr_protocol_constant
Open

apollo_network_benchmark: add SQMR protocol constant#11549
sirandreww-starkware wants to merge 1 commit into01-07-apollo_network_benchmark_added_ping_latency_metricsfrom
01-08-apollo_network_benchmark_add_sqmr_protocol_constant

Conversation

@sirandreww-starkware
Copy link
Contributor

@sirandreww-starkware sirandreww-starkware commented Jan 8, 2026

Note

Low Risk
Low risk: adds a single string constant with no behavioral changes; impact is limited to any future code that starts referencing this identifier.

Overview
Defines SQMR_PROTOCOL_NAME ("/stress-test/1.0.0") in broadcast_network_stress_test_node/protocol.rs for use as a stable protocol identifier in the network stress test node.

Written by Cursor Bugbot for commit 13f2310. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

sirandreww-starkware commented Jan 8, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jan 8, 2026
@sirandreww-starkware sirandreww-starkware marked this pull request as ready for review January 8, 2026 17:42
@sirandreww-starkware sirandreww-starkware self-assigned this Jan 8, 2026
@github-actions
Copy link

github-actions bot commented Feb 8, 2026

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale label Feb 8, 2026
@github-actions github-actions bot closed this Feb 16, 2026
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.


pub type TopicType = Vec<u8>;

pub const SQMR_PROTOCOL_NAME: &str = "/stress-test/1.0.0";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused SQMR protocol constant added

Low Severity

SQMR_PROTOCOL_NAME is introduced in protocol.rs but is never referenced anywhere in the codebase. This leaves dead code in the stress test protocol path and can mislead readers into assuming SQMR is wired when the current logic still only uses NetworkProtocol::Gossipsub.

Fix in Cursor Fix in Web

@sirandreww-starkware sirandreww-starkware force-pushed the 01-08-apollo_network_benchmark_add_sqmr_protocol_constant branch from 4083c5d to 9b3fdfa Compare February 16, 2026 09:10
@github-actions github-actions bot removed the stale label Feb 17, 2026
@sirandreww-starkware sirandreww-starkware force-pushed the 01-08-apollo_network_benchmark_add_sqmr_protocol_constant branch from 9b3fdfa to 766686d Compare February 19, 2026 07:24
@sirandreww-starkware sirandreww-starkware force-pushed the 01-07-apollo_network_benchmark_added_ping_latency_metrics branch from 5e4a06d to 4cf8b68 Compare February 19, 2026 07:24
@sirandreww-starkware sirandreww-starkware force-pushed the 01-07-apollo_network_benchmark_added_ping_latency_metrics branch from 4cf8b68 to c5160fd Compare February 19, 2026 08:04
@sirandreww-starkware sirandreww-starkware force-pushed the 01-08-apollo_network_benchmark_add_sqmr_protocol_constant branch from 766686d to 3abc921 Compare February 19, 2026 08:04
@sirandreww-starkware sirandreww-starkware force-pushed the 01-07-apollo_network_benchmark_added_ping_latency_metrics branch from c5160fd to 3bad93e Compare March 16, 2026 15:13
@sirandreww-starkware sirandreww-starkware force-pushed the 01-08-apollo_network_benchmark_add_sqmr_protocol_constant branch from 3abc921 to 13f2310 Compare March 16, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants