apollo_network_benchmark: add TCP metrics definitions#11561
apollo_network_benchmark: add TCP metrics definitions#11561sirandreww-starkware wants to merge 1 commit intographite-base/11561from
Conversation
|
This change is |
|
There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. |
sirandreww-starkware
force-pushed
the
01-08-apollo_network_benchmark_add_tcp_metrics_definitions
branch
from
d938017 to
e743c39
Compare
sirandreww-starkware
force-pushed
the
01-08-apollo_network_benchmark_implement_roundrobin_broadcasting_logic
branch
from
5ad7f33 to
5b95193
Compare
sirandreww-starkware
force-pushed
the
01-08-apollo_network_benchmark_add_tcp_metrics_definitions
branch
from
e743c39 to
1c3918f
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| LabeledMetricCounter { NETWORK_DROPPED_BROADCAST_MESSAGES, "network_dropped_broadcast_messages", "Number of dropped broadcast messages by reason", init = 0, labels = NETWORK_BROADCAST_DROP_LABELS }, | ||
| LabeledMetricCounter { NETWORK_EVENT_COUNTER, "network_event_counter", "Network events counter by type", init = 0, labels = EVENT_TYPE_LABELS }, | ||
|
|
||
| // system metrics for the node |
There was a problem hiding this comment.
Removed metrics still referenced in system_metrics file
Low Severity
The 11 removed system metric constants (SYSTEM_TOTAL_MEMORY_BYTES, SYSTEM_AVAILABLE_MEMORY_BYTES, SYSTEM_USED_MEMORY_BYTES, SYSTEM_CPU_COUNT, SYSTEM_PROCESS_CPU_USAGE_PERCENT, SYSTEM_PROCESS_MEMORY_USAGE_BYTES, SYSTEM_PROCESS_VIRTUAL_MEMORY_USAGE_BYTES, SYSTEM_NETWORK_BYTES_SENT_TOTAL, SYSTEM_NETWORK_BYTES_RECEIVED_TOTAL, SYSTEM_NETWORK_BYTES_SENT_CURRENT, SYSTEM_NETWORK_BYTES_RECEIVED_CURRENT) are still imported and used in system_metrics.rs. While that file isn't currently compiled (no mod system_metrics; in main.rs), this removal leaves it in a permanently broken state. The orphaned file and its now-invalid imports are worth cleaning up together.
sirandreww-starkware
changed the base branch from
01-08-apollo_network_benchmark_implement_roundrobin_broadcasting_logic
to
graphite-base/11561
2 participants
Note
Medium Risk
Removing metric definitions can break compilation or runtime observability where
SYSTEM_*metrics are still referenced (e.g.,system_metrics.rs) and changes what monitoring dashboards can rely on.Overview
Removes the system/process/network interface metric definitions (memory, CPU, per-process usage, and host network bytes) from
broadcast_network_stress_test_node’sdefine_metrics!list, leaving only broadcast/network andPING_LATENCY_SECONDSmetrics.This effectively narrows the exported metrics surface for the stress-test node and may require updating any code that still references the removed
SYSTEM_*metrics (e.g., collectors wiring them up).Written by Cursor Bugbot for commit 1c3918f. This will update automatically on new commits. Configure here.