Skip to content

apollo_network_benchmark: added SQMR session metrics#11546

Open
sirandreww-starkware wants to merge 1 commit into01-07-apollo_network_benchmark_added_broadcast_topic_metricsfrom
01-07-apollo_network_benchmark_added_sqmr_session_metrics
Open

apollo_network_benchmark: added SQMR session metrics#11546
sirandreww-starkware wants to merge 1 commit into01-07-apollo_network_benchmark_added_broadcast_topic_metricsfrom
01-07-apollo_network_benchmark_added_sqmr_session_metrics

Conversation

@sirandreww-starkware
Copy link
Contributor

@sirandreww-starkware sirandreww-starkware commented Jan 8, 2026

Note

Low Risk
Low risk: benchmark-only metrics additions that don’t affect network behavior, just observability wiring. Main risk is incorrect/unused registration leading to missing or misleading gauges.

Overview
The broadcast network stress test node now reports SQMR session activity by adding gauges for active inbound/outbound sessions.

create_network_metrics() is updated to construct SqmrNetworkMetrics and pass it via NetworkMetrics.sqmr_metrics (previously None), enabling these metrics to be exported alongside existing peer and broadcast metrics.

Written by Cursor Bugbot for commit 74f56ff. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

sirandreww-starkware commented Jan 8, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jan 8, 2026
@sirandreww-starkware sirandreww-starkware marked this pull request as ready for review January 8, 2026 17:42
@sirandreww-starkware sirandreww-starkware self-assigned this Jan 8, 2026
@github-actions
Copy link

github-actions bot commented Feb 8, 2026

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale label Feb 8, 2026
@github-actions github-actions bot closed this Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants