apollo_network_benchmark: moved metric declerations to crate#12724
Open
sirandreww-starkware wants to merge 1 commit into02-18-apollo_network_benchmark_renamed_node_binaryfrom
Conversation
This was referenced Feb 19, 2026
This was referenced Feb 19, 2026
Contributor
Author
This was referenced Feb 19, 2026
f32a6eb to
9fd8303
Compare
guy-starkware
approved these changes
Feb 19, 2026
Contributor
guy-starkware
left a comment
There was a problem hiding this comment.
@guy-starkware reviewed 3 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on sirandreww-starkware).
9fd8303 to
80cca2e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Low Risk
Low risk refactor that relocates metric declarations without changing metric names or how they’re registered, but could affect consumers via module exports if paths/imports were relied on.
Overview
Moves all
define_metrics!metric declarations out of the benchmark node binary into a new crate-level module (apollo_network_benchmark::metrics) and exports it fromlib.rs.Updates the node binary to
pub usethe shared metrics instead of defining them locally, keeping the existingregister_metricsand helper functions intact.Written by Cursor Bugbot for commit 80cca2e. This will update automatically on new commits. Configure here.