Skip to content

apollo_network_benchmark: moved metric declerations to crate#12724

Open
sirandreww-starkware wants to merge 1 commit into02-18-apollo_network_benchmark_renamed_node_binaryfrom
02-18-apollo_network_benchmark_moved_metric_declerations_to_crate
Open

apollo_network_benchmark: moved metric declerations to crate#12724
sirandreww-starkware wants to merge 1 commit into02-18-apollo_network_benchmark_renamed_node_binaryfrom
02-18-apollo_network_benchmark_moved_metric_declerations_to_crate

Conversation

@sirandreww-starkware
Copy link
Contributor

@sirandreww-starkware sirandreww-starkware commented Feb 19, 2026

Note

Low Risk
Low risk refactor that relocates metric declarations without changing metric names or how they’re registered, but could affect consumers via module exports if paths/imports were relied on.

Overview
Moves all define_metrics! metric declarations out of the benchmark node binary into a new crate-level module (apollo_network_benchmark::metrics) and exports it from lib.rs.

Updates the node binary to pub use the shared metrics instead of defining them locally, keeping the existing register_metrics and helper functions intact.

Written by Cursor Bugbot for commit 80cca2e. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

sirandreww-starkware commented Feb 19, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@sirandreww-starkware sirandreww-starkware marked this pull request as ready for review February 19, 2026 07:27
@sirandreww-starkware sirandreww-starkware force-pushed the 02-18-apollo_network_benchmark_moved_metric_declerations_to_crate branch from f32a6eb to 9fd8303 Compare February 19, 2026 08:04
Copy link
Contributor

@guy-starkware guy-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guy-starkware reviewed 3 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on sirandreww-starkware).

@sirandreww-starkware sirandreww-starkware force-pushed the 02-18-apollo_network_benchmark_moved_metric_declerations_to_crate branch from 9fd8303 to 80cca2e Compare March 16, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants