apollo_network_benchmark: added broadcast topic metrics

[sirandreww-starkware]

Note

Low Risk
Low risk benchmark-only change that wires additional broadcast send/receive/drop counters into NetworkMetrics for the stress-test topic; main risk is metric label/mapping mistakes affecting observability, not runtime behavior.

Overview
Adds per-topic broadcast observability to the broadcast network stress test node by defining new counters for sent/received messages and a labeled counter for dropped broadcasts (using NETWORK_BROADCAST_DROP_LABELS).

Updates create_network_metrics() to populate NetworkMetrics.broadcast_metrics_by_topic with a BroadcastNetworkMetrics entry keyed by the stress-test TOPIC hash, so the network manager can record broadcast metrics for that topic.

^{Written by Cursor Bugbot for commit 5095a65. This will update automatically on new commits. Configure here.}

[reviewable-StarkWare]

This change is 

[sirandreww-starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• apollo_network_benchmark: implement RoundRobin broadcasting logic #11560 : 3 dependent PRs (#11561 , #12722 , #13288 )
• apollo_network_benchmark: add seconds_since_epoch helper function #11559
• apollo_network_benchmark: add RoundRobin mode to enum and round_duration_seconds arg #11558
• apollo_network_benchmark: add message index detection mechanism #11557
• apollo_network_benchmark: add MessageIndexTracker struct #11556
• apollo_network_benchmark: add ReveresedSqmr receiver and registration #11555
• apollo_network_benchmark: add ReveresedSqmrSender struct and implementation #11554
• apollo_network_benchmark: add ReveresedSqmr variant to NetworkProtocol enum #11553
• apollo_network_benchmark: add Sqmr variant to MessageReceiver and registration #11552
• apollo_network_benchmark: add Sqmr variant to MessageSender with send logic #11551
• apollo_network_benchmark: add Sqmr variant to NetworkProtocol enum #11550
• apollo_network_benchmark: add SQMR protocol constant #11549
• apollo_network_benchmark: added ping latency metrics #11548
• apollo_network_benchmark: added network event metrics #11547
• apollo_network_benchmark: added SQMR session metrics #11546
• apollo_network_benchmark: added broadcast topic metrics #11545 👈 (View in Graphite)
• apollo_network_benchmark: added network metrics to network manager #11544
• apollo_network_benchmark: added broadcast metrics tracking #11543
• apollo_network_benchmark: added conditional broadcasting based on mode #11542
• apollo_network_benchmark: added broadcasting mode selection #11541
• apollo_network_benchmark: added message broadcasting task #10734 : 1 other dependent PR (#8303 )
• apollo_network_benchmark: added register metrics #10660 : 1 other dependent PR (#10661 )
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[guy-starkware]

@guy-starkware reviewed 1 file and all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @noamsp-starkware).

[github-actions]

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

[cursor]

New broadcast metrics are never registered

Medium Severity

The three newly added metrics — NETWORK_STRESS_TEST_SENT_MESSAGES, NETWORK_STRESS_TEST_RECEIVED_MESSAGES, and NETWORK_DROPPED_BROADCAST_MESSAGES — are defined in the define_metrics! macro and wired into BroadcastNetworkMetrics in create_network_metrics(), but register_metrics() was not updated to call .register() on any of them. Without registration, increments to these counters won't be reported by the metrics system, defeating the purpose of this PR.

Additional Locations (1)

• crates/apollo_network_benchmark/src/bin/broadcast_network_stress_test_node/metrics.rs#L29-L32