apollo_network_benchmark: added Serialze to args#12722
Open
Conversation
This was referenced Feb 19, 2026
|
This change is |
This was referenced Feb 19, 2026
This was referenced Feb 19, 2026
Contributor
Author
This was referenced Feb 19, 2026
sirandreww-starkware
changed the base branch from
01-08-apollo_network_benchmark_add_collect_tcp_metrics_and_integrate_into_monitoring_loop
to
graphite-base/12722
sirandreww-starkware
force-pushed
the
02-18-apollo_network_benchmark_added_serialze_to_args
branch
from
ca19743 to
f9fbf59
Compare
guy-starkware
approved these changes
Feb 19, 2026
Contributor
guy-starkware
left a comment
guy-starkware
left a comment
There was a problem hiding this comment.
@guy-starkware reviewed 1 file and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on sirandreww-starkware).
sirandreww-starkware
force-pushed
the
02-18-apollo_network_benchmark_added_serialze_to_args
branch
from
f9fbf59 to
a466b76
Compare
sirandreww-starkware
changed the base branch from
graphite-base/12722
to
01-08-apollo_network_benchmark_implement_roundrobin_broadcasting_logic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Low risk: adds
Serializederive toUserArgswithout changing CLI parsing, defaults, or runtime behavior.Overview
Enables serialization of benchmark user CLI arguments by deriving
SerializeforUserArgsinapollo_network_benchmark.Written by Cursor Bugbot for commit a466b76. This will update automatically on new commits. Configure here.