apollo_network_benchmark: added conditional broadcasting based on mode#11542
Conversation
Contributor
Author
This was referenced Jan 8, 2026
|
There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. |
d045989 to
3c87686
Compare
502522a to
1165b86
Compare
3c87686 to
0576296
Compare
0e35ff2 to
a56150d
Compare
0576296 to
5bed725
Compare
This was referenced Feb 19, 2026
a56150d to
345946a
Compare
5bed725 to
030490b
Compare
030490b to
e340ed6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Note
Low Risk
Low risk benchmark-only behavior change that gates message sending on
modeand may alter load characteristics; failures are limited to the stress test harness (with an explicit panic if--broadcasteris missing inonemode).Overview
Adds mode-aware broadcasting to the broadcast network stress test node: in
allmode every node sends messages, while inonemode only the configured--broadcasternode starts the sender task.start_message_sendernow returnsOption<BoxFuture<()>>andget_tasksonly spawns the sender when applicable, with additional logging to make per-node broadcast behavior explicit.Written by Cursor Bugbot for commit e340ed6. This will update automatically on new commits. Configure here.