Skip to content

apollo_network_benchmark: added conditional broadcasting based on mode#11542

Open
sirandreww-starkware wants to merge 1 commit into01-07-apollo_network_benchmark_added_broadcasting_mode_selectionfrom
01-07-apollo_network_benchmark_added_conditional_broadcasting_based_on_mode
Open

apollo_network_benchmark: added conditional broadcasting based on mode#11542
sirandreww-starkware wants to merge 1 commit into01-07-apollo_network_benchmark_added_broadcasting_mode_selectionfrom
01-07-apollo_network_benchmark_added_conditional_broadcasting_based_on_mode

Conversation

@sirandreww-starkware
Copy link
Contributor

@sirandreww-starkware sirandreww-starkware commented Jan 8, 2026

Note

Low Risk
Low risk benchmark-only behavior change that gates message sending on mode and may alter load characteristics; failures are limited to the stress test harness (with an explicit panic if --broadcaster is missing in one mode).

Overview
Adds mode-aware broadcasting to the broadcast network stress test node: in all mode every node sends messages, while in one mode only the configured --broadcaster node starts the sender task.

start_message_sender now returns Option<BoxFuture<()>> and get_tasks only spawns the sender when applicable, with additional logging to make per-node broadcast behavior explicit.

Written by Cursor Bugbot for commit e340ed6. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

sirandreww-starkware commented Jan 8, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jan 8, 2026
@sirandreww-starkware sirandreww-starkware marked this pull request as ready for review January 8, 2026 17:42
@sirandreww-starkware sirandreww-starkware self-assigned this Jan 8, 2026
@github-actions
Copy link

github-actions bot commented Feb 8, 2026

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale label Feb 8, 2026
@github-actions github-actions bot closed this Feb 16, 2026
@sirandreww-starkware sirandreww-starkware force-pushed the 01-07-apollo_network_benchmark_added_conditional_broadcasting_based_on_mode branch from d045989 to 3c87686 Compare February 16, 2026 09:10
@sirandreww-starkware sirandreww-starkware force-pushed the 01-07-apollo_network_benchmark_added_broadcasting_mode_selection branch from 502522a to 1165b86 Compare February 16, 2026 09:10
@sirandreww-starkware sirandreww-starkware force-pushed the 01-07-apollo_network_benchmark_added_conditional_broadcasting_based_on_mode branch from 3c87686 to 0576296 Compare February 18, 2026 13:19
@sirandreww-starkware sirandreww-starkware force-pushed the 01-07-apollo_network_benchmark_added_broadcasting_mode_selection branch 2 times, most recently from 0e35ff2 to a56150d Compare February 19, 2026 07:24
@sirandreww-starkware sirandreww-starkware force-pushed the 01-07-apollo_network_benchmark_added_conditional_broadcasting_based_on_mode branch from 0576296 to 5bed725 Compare February 19, 2026 07:24
@sirandreww-starkware sirandreww-starkware force-pushed the 01-07-apollo_network_benchmark_added_broadcasting_mode_selection branch from a56150d to 345946a Compare February 19, 2026 08:04
@sirandreww-starkware sirandreww-starkware force-pushed the 01-07-apollo_network_benchmark_added_conditional_broadcasting_based_on_mode branch from 5bed725 to 030490b Compare February 19, 2026 08:04
@github-actions github-actions bot removed the stale label Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants