Skip to content

apollo_network_benchmark: add get_tcp_stats function#11562

Closed
sirandreww-starkware wants to merge 1 commit into01-08-apollo_network_benchmark_add_tcp_metrics_definitionsfrom
01-08-apollo_network_benchmark_add_get_tcp_stats_function
Closed

apollo_network_benchmark: add get_tcp_stats function#11562
sirandreww-starkware wants to merge 1 commit into01-08-apollo_network_benchmark_add_tcp_metrics_definitionsfrom
01-08-apollo_network_benchmark_add_get_tcp_stats_function

Conversation

@sirandreww-starkware
Copy link
Contributor

@sirandreww-starkware sirandreww-starkware commented Jan 8, 2026

Note

Low Risk
Adds a new, currently unused /proc parsing helper; no behavior changes unless it is later integrated into the metrics pipeline.

Overview
Adds a new Linux-only helper get_tcp_stats() in system_metrics.rs that parses /proc/net/snmp to extract TCP OutSegs and RetransSegs, with warning logs on read/parse/format issues.

The function is currently unused (guarded by #[allow(dead_code)]), so runtime behavior of the benchmark node is unchanged until it’s wired into metric collection.

Written by Cursor Bugbot for commit 17e3518. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

sirandreww-starkware commented Jan 8, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link

github-actions bot commented Feb 8, 2026

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale label Feb 8, 2026
@github-actions github-actions bot closed this Feb 16, 2026
@sirandreww-starkware sirandreww-starkware force-pushed the 01-08-apollo_network_benchmark_add_tcp_metrics_definitions branch from d938017 to e743c39 Compare February 16, 2026 09:10
@sirandreww-starkware sirandreww-starkware force-pushed the 01-08-apollo_network_benchmark_add_get_tcp_stats_function branch from 78ebb8b to 062bff3 Compare February 16, 2026 09:10
@github-actions github-actions bot removed the stale label Feb 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants