Skip to content

apollo_network_benchmark: add RoundRobin mode to enum and round_duration_seconds arg#11558

Open
sirandreww-starkware wants to merge 1 commit into01-08-apollo_network_benchmark_add_message_index_detection_mechanismfrom
01-08-apollo_network_benchmark_add_roundrobin_mode_to_enum_and_round_duration_seconds_arg
Open

apollo_network_benchmark: add RoundRobin mode to enum and round_duration_seconds arg#11558
sirandreww-starkware wants to merge 1 commit into01-08-apollo_network_benchmark_add_message_index_detection_mechanismfrom
01-08-apollo_network_benchmark_add_roundrobin_mode_to_enum_and_round_duration_seconds_arg

Conversation

@sirandreww-starkware
Copy link
Contributor

@sirandreww-starkware sirandreww-starkware commented Jan 8, 2026

Note

Low Risk
Low risk: changes are limited to CLI argument parsing and a simple conditional that treats RoundRobin like AllBroadcast; no core network/protocol logic is modified.

Overview
Adds a new stress-test Mode::RoundRobin (--mode rr) plus a --round-duration-seconds user arg (default 3) intended to control per-node broadcast rotation.

Updates BroadcastNetworkStressTestNode::should_broadcast so RoundRobin nodes are allowed to broadcast (same behavior as AllBroadcast).

Written by Cursor Bugbot for commit 04b68d7. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

sirandreww-starkware commented Jan 8, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link

github-actions bot commented Feb 8, 2026

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale label Feb 8, 2026
@github-actions github-actions bot closed this Feb 16, 2026
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

pub fn should_broadcast(&self) -> bool {
match self.args.user.mode {
Mode::AllBroadcast => true,
Mode::AllBroadcast | Mode::RoundRobin => true,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RoundRobin mode behaves identically to AllBroadcast mode

Medium Severity

Mode::RoundRobin is grouped with Mode::AllBroadcast in should_broadcast, making all nodes broadcast simultaneously. This means selecting --mode rr produces identical behavior to --mode all — no turn-taking occurs and round_duration_seconds is never consulted anywhere. Users of this mode will get misleading behavior with no indication that round-robin isn't actually happening.

Fix in Cursor Fix in Web

@sirandreww-starkware sirandreww-starkware force-pushed the 01-08-apollo_network_benchmark_add_message_index_detection_mechanism branch from a581d33 to c7ca4ed Compare February 16, 2026 09:10
@sirandreww-starkware sirandreww-starkware force-pushed the 01-08-apollo_network_benchmark_add_roundrobin_mode_to_enum_and_round_duration_seconds_arg branch from 5027f26 to 64dcc25 Compare February 16, 2026 09:10
@github-actions github-actions bot removed the stale label Feb 17, 2026
@sirandreww-starkware sirandreww-starkware force-pushed the 01-08-apollo_network_benchmark_add_message_index_detection_mechanism branch from c7ca4ed to f10f148 Compare February 19, 2026 07:24
@sirandreww-starkware sirandreww-starkware force-pushed the 01-08-apollo_network_benchmark_add_roundrobin_mode_to_enum_and_round_duration_seconds_arg branch from 64dcc25 to 8cd5e64 Compare February 19, 2026 07:24
@sirandreww-starkware sirandreww-starkware force-pushed the 01-08-apollo_network_benchmark_add_roundrobin_mode_to_enum_and_round_duration_seconds_arg branch from 8cd5e64 to f8aaeb3 Compare February 19, 2026 08:04
@sirandreww-starkware sirandreww-starkware force-pushed the 01-08-apollo_network_benchmark_add_message_index_detection_mechanism branch from 6bed8fb to 2186fdd Compare March 16, 2026 15:13
@sirandreww-starkware sirandreww-starkware force-pushed the 01-08-apollo_network_benchmark_add_roundrobin_mode_to_enum_and_round_duration_seconds_arg branch from f8aaeb3 to 04b68d7 Compare March 16, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants