apollo_network_benchmark: add RoundRobin mode to enum and round_duration_seconds arg#11558
Conversation
This was referenced Jan 8, 2026
Contributor
Author
This was referenced Jan 8, 2026
|
There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale. |
| pub fn should_broadcast(&self) -> bool { | ||
| match self.args.user.mode { | ||
| Mode::AllBroadcast => true, | ||
| Mode::AllBroadcast | Mode::RoundRobin => true, |
There was a problem hiding this comment.
RoundRobin mode behaves identically to AllBroadcast mode
Medium Severity
Mode::RoundRobin is grouped with Mode::AllBroadcast in should_broadcast, making all nodes broadcast simultaneously. This means selecting --mode rr produces identical behavior to --mode all — no turn-taking occurs and round_duration_seconds is never consulted anywhere. Users of this mode will get misleading behavior with no indication that round-robin isn't actually happening.
a581d33 to
c7ca4ed
Compare
5027f26 to
64dcc25
Compare
c7ca4ed to
f10f148
Compare
64dcc25 to
8cd5e64
Compare
This was referenced Feb 19, 2026
8cd5e64 to
f8aaeb3
Compare
6bed8fb to
2186fdd
Compare
f8aaeb3 to
04b68d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Note
Low Risk
Low risk: changes are limited to CLI argument parsing and a simple conditional that treats
RoundRobinlikeAllBroadcast; no core network/protocol logic is modified.Overview
Adds a new stress-test
Mode::RoundRobin(--mode rr) plus a--round-duration-secondsuser arg (default3) intended to control per-node broadcast rotation.Updates
BroadcastNetworkStressTestNode::should_broadcastsoRoundRobinnodes are allowed to broadcast (same behavior asAllBroadcast).Written by Cursor Bugbot for commit 04b68d7. This will update automatically on new commits. Configure here.