Skip to content

apollo_network_benchmark: renamed node binary#12723

Open
sirandreww-starkware wants to merge 1 commit into02-18-apollo_network_benchmark_added_serialze_to_argsfrom
02-18-apollo_network_benchmark_renamed_node_binary
Open

apollo_network_benchmark: renamed node binary#12723
sirandreww-starkware wants to merge 1 commit into02-18-apollo_network_benchmark_added_serialze_to_argsfrom
02-18-apollo_network_benchmark_renamed_node_binary

Conversation

@sirandreww-starkware
Copy link
Contributor

@sirandreww-starkware sirandreww-starkware commented Feb 19, 2026

Note

Low Risk
Low risk code change; primarily a packaging/binary rename that may impact downstream scripts or deployment configs expecting the old executable name.

Overview
Renames the apollo_network_benchmark node executable to apollo_network_benchmark_node by moving the node entrypoint under src/bin/apollo_network_benchmark_node.

No functional behavior changes are evident from the diff provided; the main impact is on build/run tooling that references the previous binary name.

Written by Cursor Bugbot for commit 1e9e611. This will update automatically on new commits. Configure here.

This was referenced Feb 19, 2026
Copy link
Contributor Author

sirandreww-starkware commented Feb 19, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@reviewable-StarkWare
Copy link

This change is Reviewable

@sirandreww-starkware sirandreww-starkware self-assigned this Feb 19, 2026
@sirandreww-starkware sirandreww-starkware marked this pull request as ready for review February 19, 2026 07:27
@sirandreww-starkware sirandreww-starkware force-pushed the 02-18-apollo_network_benchmark_added_serialze_to_args branch from ca19743 to f9fbf59 Compare February 19, 2026 08:04
@sirandreww-starkware sirandreww-starkware force-pushed the 02-18-apollo_network_benchmark_renamed_node_binary branch from 650b46c to 55fc742 Compare February 19, 2026 08:04
Copy link
Contributor

@guy-starkware guy-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guy-starkware partially reviewed 8 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on sirandreww-starkware).

@sirandreww-starkware sirandreww-starkware force-pushed the 02-18-apollo_network_benchmark_added_serialze_to_args branch from f9fbf59 to a466b76 Compare March 16, 2026 15:13
@sirandreww-starkware sirandreww-starkware force-pushed the 02-18-apollo_network_benchmark_renamed_node_binary branch from 55fc742 to 1e9e611 Compare March 16, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants