apollo_network_benchmark: added network event metrics

[sirandreww-starkware]

Note

Low Risk
Low risk: adds a new labeled counter metric and plumbs it into the existing NetworkMetrics struct without changing networking behavior or data handling.

Overview
Adds a new labeled counter, NETWORK_EVENT_COUNTER (network_event_counter), to the broadcast network stress test node metrics, using EVENT_TYPE_LABELS.

Updates create_network_metrics to construct EventMetrics and pass it via NetworkMetrics.event_metrics (previously None), enabling event-type network telemetry during the benchmark.

^{Written by Cursor Bugbot for commit 21df92c. This will update automatically on new commits. Configure here.}

[reviewable-StarkWare]

This change is 

[sirandreww-starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• apollo_network_benchmark: implement RoundRobin broadcasting logic #11560 : 3 dependent PRs (#11561 , #12722 , #13288 )
• apollo_network_benchmark: add seconds_since_epoch helper function #11559
• apollo_network_benchmark: add RoundRobin mode to enum and round_duration_seconds arg #11558
• apollo_network_benchmark: add message index detection mechanism #11557
• apollo_network_benchmark: add MessageIndexTracker struct #11556
• apollo_network_benchmark: add ReveresedSqmr receiver and registration #11555
• apollo_network_benchmark: add ReveresedSqmrSender struct and implementation #11554
• apollo_network_benchmark: add ReveresedSqmr variant to NetworkProtocol enum #11553
• apollo_network_benchmark: add Sqmr variant to MessageReceiver and registration #11552
• apollo_network_benchmark: add Sqmr variant to MessageSender with send logic #11551
• apollo_network_benchmark: add Sqmr variant to NetworkProtocol enum #11550
• apollo_network_benchmark: add SQMR protocol constant #11549
• apollo_network_benchmark: added ping latency metrics #11548
• apollo_network_benchmark: added network event metrics #11547 👈 (View in Graphite)
• apollo_network_benchmark: added SQMR session metrics #11546
• apollo_network_benchmark: added broadcast topic metrics #11545
• apollo_network_benchmark: added network metrics to network manager #11544
• apollo_network_benchmark: added broadcast metrics tracking #11543
• apollo_network_benchmark: added conditional broadcasting based on mode #11542
• apollo_network_benchmark: added broadcasting mode selection #11541
• apollo_network_benchmark: added message broadcasting task #10734 : 1 other dependent PR (#8303 )
• apollo_network_benchmark: added register metrics #10660 : 1 other dependent PR (#10661 )
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

[cursor]

New event counter metric never gets registered

Medium Severity

The new NETWORK_EVENT_COUNTER metric is never registered. During NetworkManager::new(), the event_metrics field is take()n from NetworkMetrics and moved into MixedBehaviour, so when NetworkMetrics::register() runs later in run(), event_metrics is already None and the counter isn't registered. The register_metrics() function also doesn't include NETWORK_EVENT_COUNTER.register(). Other components like apollo_consensus_manager handle this by explicitly registering their event counter in their register_metrics().

Additional Locations (1)

• crates/apollo_network_benchmark/src/bin/broadcast_network_stress_test_node/metrics.rs#L107-L108