Skip to content

apollo_network_benchmark: add seconds_since_epoch helper function#11559

Open
sirandreww-starkware wants to merge 1 commit into01-08-apollo_network_benchmark_add_roundrobin_mode_to_enum_and_round_duration_seconds_argfrom
01-08-apollo_network_benchmark_add_seconds_since_epoch_helper_function
Open

apollo_network_benchmark: add seconds_since_epoch helper function#11559
sirandreww-starkware wants to merge 1 commit into01-08-apollo_network_benchmark_add_roundrobin_mode_to_enum_and_round_duration_seconds_argfrom
01-08-apollo_network_benchmark_add_seconds_since_epoch_helper_function

Conversation

@sirandreww-starkware
Copy link
Contributor

@sirandreww-starkware sirandreww-starkware commented Jan 8, 2026

Note

Low Risk
Adds a small utility function and adjusts imports in a benchmark binary; minimal behavioral impact aside from potential panic if system time is before the Unix epoch.

Overview
Adds seconds_since_epoch() to broadcast_network_stress_test_node/metrics.rs to expose the current Unix timestamp in seconds (via SystemTime/UNIX_EPOCH). Updates the module’s std::time imports accordingly; no other benchmark/metrics logic changes.

Written by Cursor Bugbot for commit 1d13062. This will update automatically on new commits. Configure here.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

sirandreww-starkware commented Jan 8, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link

github-actions bot commented Feb 8, 2026

There hasn't been any activity on this pull request recently, and in order to prioritize active work, it has been marked as stale.
This PR will be closed and locked in 7 days if no further activity occurs.
Thank you for your contributions!

@github-actions github-actions bot added the stale label Feb 8, 2026
@github-actions github-actions bot closed this Feb 16, 2026
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

pub fn seconds_since_epoch() -> u64 {
let now = SystemTime::now();
now.duration_since(UNIX_EPOCH).unwrap().as_secs()
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New exported function seconds_since_epoch is unused

Low Severity

The newly added pub fn seconds_since_epoch() has no callers anywhere in the codebase. A grep for seconds_since_epoch returns only the definition itself. If this is intended for a downstream PR in the stack, it may be better to introduce it together with its usage to avoid dead code in the interim.

Fix in Cursor Fix in Web

@sirandreww-starkware sirandreww-starkware force-pushed the 01-08-apollo_network_benchmark_add_seconds_since_epoch_helper_function branch from 6e7d057 to ffaea93 Compare February 16, 2026 09:10
@github-actions github-actions bot removed the stale label Feb 17, 2026
@sirandreww-starkware sirandreww-starkware force-pushed the 01-08-apollo_network_benchmark_add_seconds_since_epoch_helper_function branch from ffaea93 to c686f08 Compare February 19, 2026 07:24
@sirandreww-starkware sirandreww-starkware force-pushed the 01-08-apollo_network_benchmark_add_roundrobin_mode_to_enum_and_round_duration_seconds_arg branch from 64dcc25 to 8cd5e64 Compare February 19, 2026 07:24
@sirandreww-starkware sirandreww-starkware force-pushed the 01-08-apollo_network_benchmark_add_roundrobin_mode_to_enum_and_round_duration_seconds_arg branch from 8cd5e64 to f8aaeb3 Compare February 19, 2026 08:04
@sirandreww-starkware sirandreww-starkware force-pushed the 01-08-apollo_network_benchmark_add_seconds_since_epoch_helper_function branch from c686f08 to a5e0165 Compare February 19, 2026 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants